similar issues:
#1387040: Bug in states.js when minified
#1386976: Bug in drupal.js when minified
#1387002: Bug in overlay-parent.js when minified

(I thought those are wrongly reported. It isn't buggies but code improves.)

CommentFileSizeAuthor
js_semicolon.patch1.54 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

patrickd’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, could be applied successfully, I think there is not much to discuss about.

sun’s picture

Issue tags: +JavaScript clean-up
+++ b/core/modules/menu/menu.admin.js
@@ -42,6 +42,6 @@
-  }
+  };
 
 })(jQuery);

This entire file shouldn't be indented in the first place. Let's open a follow-up issue for that.

+++ b/core/modules/shortcut/shortcut.admin.js
@@ -79,7 +79,7 @@ Drupal.behaviors.shortcutDrag = {
-      };
+      }

This shouldn't be a local function in the first place. Let's open a follow-up issue for that.

droplet’s picture

quick patches,

#1, #1420048: fix menu* JS indention
#2, #1420056: moving shortcut local var

(im going out, leave me message. I will check when back. Thanks all reviews.)

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x and backported to 7.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.