Needed to get this module implemented on a D7 site today, so I made a few fixes to 7.x-3.x-dev. Really sorry, but I didn't have time to put them together as separate patches.

* Per content type settings were not shown for a few reasons (one being module weight < Notifications module). I spun them out to a separate fieldset.
* Add per content type setting for user selection View.
* Fix db_query errors on comment submit - db_query calls to use D7 syntax.
* Fix link to Administer Content Types Page
* Fix typo in documentation s/Only/Ony

I didn't get auto-complete working, but I don't need it for my use case. I think it just needs some tweaks to the default view and notifications_team_get_users() to filter properly.

Patch to follow in a sec.

CommentFileSizeAuthor
#2 team-ui-per-content-type-user-view-1400034.patch4.91 KBwebflo
#1 notifications_team_d7.patch12.01 KBjtolj
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jtolj’s picture

jtolj CreditAttribution: jtolj commented
FileSize
notifications_team_d7.patch12.01 KB

Patch for above.

webflo’s picture

webflo CreditAttribution: webflo commented
Title: Fixes for 7.x-3.x-dev » Add per content type setting for user selection View.
Category: bug » feature
FileSize
team-ui-per-content-type-user-view-1400034.patch4.91 KB

Hi,

thanks for you patch. I merged the most of into 7.x-3.x-dev.

Fixed

  • Per content type settings were not shown for a few reasons (one being module weight < Notifications module). I spun them out to a separate fieldset.
  • Fix db_query errors on comment submit - db_query calls to use D7 syntax.
  • Fix link to Administer Content Types Page
  • Fix typo in documentation s/Only/Ony

Todo

  • Add per content type setting for user selection View.

This makes this issue a feature request. I rerolled this patch against 7.x-3.x-dev.

webflo’s picture

webflo CreditAttribution: webflo commented
Issue summary: View changes

typo