strict warning appears after creation of first workflow [#1400352]

0. I've installed the workflow module

1. I entered /admin/config/workflow/workflow

2. I entered a workflow-name on /admin/config/workflow/workflow/add

3. I clicked "Add Workflow" and after loading the page, where I can insert the first state i got the warning:

Strict warning: Only variables should be passed by reference in workflow_admin_ui_overview() (line 756 of C:\xampp\htdocs\niku_formular_online\sites\all\modules\contrib\workflow\workflow_admin_ui\workflow_admin_ui.module).

Here's the screenshot:

warning

I have the following workflow-modules enabled:

Workflow access
Workflow rules
Workflow UI
Workflow views

Thank you for your help with fixing the problem!

Comment	File	Size	Author
	strict_warning.jpg	275.64 KB	sbrege

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

sbrege CreditAttribution: sbrege commented 11 January 2012 at 12:57

Assigned:

sbrege

» Unassigned

Comment #2

sbrege CreditAttribution: sbrege commented 20 January 2012 at 16:58

Hello,

Can anybody help me here with this problem.

I think workflow is a great module, but I don't know if there is something to do with the error.

Thank you,

Stefan

Comment #3

sbrege CreditAttribution: sbrege commented 26 January 2012 at 23:14

Is this a bug like http://drupal.org/node/1090982?

There are also other warnings like this: http://www.google.de/search?gcx=c&sourceid=chrome&ie=UTF-8&q=Strict+warn...

Comment #4

Bastlynn CreditAttribution: Bastlynn commented 4 February 2012 at 22:15

This is actually more related to this sort of error: http://www.trash-factor.com/content/php-error-creating-default-object-em...

I've added a line to create $state before trying to reference the property in it. That should take care of things. The change is on the 7.x dev branch at this point.

Comment #5

Bastlynn CreditAttribution: Bastlynn commented 4 February 2012 at 22:15

Status:

Active

» Needs review

Please let me know if it works for you.

Comment #6

sbrege CreditAttribution: sbrege commented 6 February 2012 at 08:49

Hello,

thanks for you help. I'll tell you on Wednesday 08. Feb. if your fix will work!

Thanks,

Stefan

Comment #7

sbrege CreditAttribution: sbrege commented 9 February 2012 at 20:52

Hello,

please tell me, if I made a mistake (I'm new with git):

On my git a entered:
git clone --branch 7.x-1.x http://git.drupal.org/project/workflow.git
cd workflow
git checkout 7.x-1.x

Then on my filesystem (I'm using windows 7):
I moved the workflow directory from git (I got the location via pwd) in my installation of drupal.
I run the update.php.

Then in drupal:
I tried to create a new workflow. The result was the same:

Strict warning: Only variables should be passed by reference in workflow_admin_ui_overview() (line 757 of C:\xampp\htdocs\niku_abgleich\sites\all\modules\contrib\workflow\workflow_admin_ui\workflow_admin_ui.module).

Just for info I've set up a test installation with the same module-configuration as my actual development-site.

So if I have done everything right, then the bug is not fixed yet. When I've made a mistake please tell me about that.

Thank you for developement!

Stefan

Comment #8

Bastlynn CreditAttribution: Bastlynn commented 7 March 2012 at 16:51

Status:

Needs review

» Closed (duplicate)

I think this issue #1418268: Strict warning: Only variables should be passed by reference in workflow_tab_page() is addressing the same problem. If so, the patch should be in on dev at this point. It sounds roughly like you have the correct setup. Try it again?