Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If I supply a custom start position in the style settings, the carousel insists on starting at the first item. I need to investigate this as it seems to work fine when I manually set options.start in the jcarousel JS.
Comment | File | Size | Author |
---|---|---|---|
#7 | 1401890.2-pager-start-position.patch | 2.49 KB | don ferrando |
#6 | 1401890.1-pager-start-position.patch | 2.61 KB | deviantintegral |
Comments
Comment #1
deviantintegral CreditAttribution: deviantintegral commentedComment #2
deviantintegral CreditAttribution: deviantintegral commentedTo clarify this: it looks like the start setting is having an effect, but it's quite inconsistent with the pager behaviour. I'm investigating to see exactly what the issue is.
Comment #3
deviantintegral CreditAttribution: deviantintegral commentedSo, it looks like the actual issue is that the pager doesn't work well with custom start positions.
Comment #4
deviantintegral CreditAttribution: deviantintegral commentedHere's a patch that sets the appropriate pager position when options.start is customized. I've only tested this on 6.x, but this patch applies identically to 7.x, so I'm assuming it will work there. I'll review this on 7.x tomorrow unless someone beats me to it.
Comment #5
quicksketchLooks like d.o ate your patch. Could you re-upload?
Comment #6
deviantintegral CreditAttribution: deviantintegral commentedLet's try this again.
Comment #7
don ferrando CreditAttribution: don ferrando commentedYour patch breaks the pager, when options.start is NOT customized. You can replace
by