I receive the following error when I attempt to access /access_token without an expires parameter:

Notice: Undefined index: expires in oauth_common_callback_access_token() (line 359 of /var/www/drupal/sites/all/modules/oauth/oauth_common.pages.inc).

I'm not sure how to submit a patch. If you change line 359 referred above to include an isset(), it seems to work:

if (isset($_GET['expires']) && intval($_GET['expires'])) {

Comments

Title:When an expires value is not included in an /access_token request, a PHP warning is generatedPHP notices generated when an expires value is not included in an /access_token request and when callback URL has no query
Version:7.x-3.0-alpha2» 7.x-3.x-dev
Priority:Minor» Normal
Status:Active» Needs review
StatusFileSize
new1.15 KB

I was writing some simpletests for our oauth flow and ran into this notice, as well as an "Undefined index: query" notice that's emitted on line 121 of oauth_common.pages.inc if the callback URL for your oauth consumer doesn't include a query string.

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new1.15 KB

Patch needed a re-roll.

verified that it fixes the notices.

Version:7.x-3.x-dev» 6.x-3.x-dev
Status:Reviewed & tested by the community» Needs work

Status:Needs work» Patch (to be ported)

Updating to proper status per issue queue handbook.

Status:Patch (to be ported)» Needs review
StatusFileSize
new1.08 KB

I couldn't apply the patch because it's for D7. I added by hand and created patch for it.