Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem:
When we have an untranslated term taxonomy_catalog with und language code and the product node has language->XX, in my case ro, the function _uc_catalog_navigation($branch) is not working properly so the path is not collapsed in the catalog block.
I'll upload the patch to solve this in next comment.
Comment | File | Size | Author |
---|---|---|---|
#5 | 1408156-catalog-taxonomy-language.patch | 1.39 KB | longwave |
#1 | uc_catalog-und_taxonomy_catalog-1408156.patch | 729 bytes | SilviuChingaru |
Comments
Comment #1
SilviuChingaru CreditAttribution: SilviuChingaru commentedThe patch to solve this.
Comment #2
SilviuChingaru CreditAttribution: SilviuChingaru commentedComment #3
SilviuChingaru CreditAttribution: SilviuChingaru commentedComment #4
TR CreditAttribution: TR commentedNeeds review is still the correct status.
Comment #5
longwaveDoesn't this also need changing in uc_catalog_node_view()? And I think we should use the field_get_value() API call instead of trying to figure out the language ourselves. Can you test the attached patch and check that both the catalog block and breadcrumbs work for your site?
Comment #6
SilviuChingaru CreditAttribution: SilviuChingaru commentedI confirm that #5 is working fine for both breadcrumb and catalog block. My patch was one in a hurry because I noticed the bug on a site already in production and must solve the problem immediately. Thank you for your patch.
Comment #7
TR CreditAttribution: TR commented@longwave: The uc_catalog_node_view() problem is the subject of a different issue, #1167348: Make taxonomy_catalog a translatable field. That other issue can be closed out if it's going to be addressed here.
Comment #8
longwaveI actually pushed this last night then immediately lost connectivity.
@TR: that issue is about the initial definition of taxonomy_catalog and whether it should be flagged as translatable or not, which is subtly different. Helpfully, the code committed here should work whether or not the field is translatable.
Comment #10
SilviuChingaru CreditAttribution: SilviuChingaru commented