Problem:
When we have an untranslated term taxonomy_catalog with und language code and the product node has language->XX, in my case ro, the function _uc_catalog_navigation($branch) is not working properly so the path is not collapsed in the catalog block.
I'll upload the patch to solve this in next comment.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SilviuChingaru’s picture

Status: Active » Needs review
FileSize
729 bytes

The patch to solve this.

SilviuChingaru’s picture

Status: Needs review » Reviewed & tested by the community
SilviuChingaru’s picture

Status: Reviewed & tested by the community » Patch (to be ported)
TR’s picture

Status: Patch (to be ported) » Needs review

Needs review is still the correct status.

longwave’s picture

Doesn't this also need changing in uc_catalog_node_view()? And I think we should use the field_get_value() API call instead of trying to figure out the language ourselves. Can you test the attached patch and check that both the catalog block and breadcrumbs work for your site?

SilviuChingaru’s picture

I confirm that #5 is working fine for both breadcrumb and catalog block. My patch was one in a hurry because I noticed the bug on a site already in production and must solve the problem immediately. Thank you for your patch.

TR’s picture

@longwave: The uc_catalog_node_view() problem is the subject of a different issue, #1167348: Make taxonomy_catalog a translatable field. That other issue can be closed out if it's going to be addressed here.

longwave’s picture

Status: Needs review » Fixed

I actually pushed this last night then immediately lost connectivity.

@TR: that issue is about the initial definition of taxonomy_catalog and whether it should be flagged as translatable or not, which is subtly different. Helpfully, the code committed here should work whether or not the field is translatable.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

SilviuChingaru’s picture

Assigned: SilviuChingaru » Unassigned
Issue summary: View changes