The current media styles feature provides some "Grid friendly" styles. This is great however it is making the assumption about what grid is being used. Would it be an idea to rethink what defaults are provided and generalize the styles a little bit more ?

Comments

MiSc’s picture

MiSc CreditAttribution: MiSc commented

Agree.

fabsor’s picture

fabsor CreditAttribution: fabsor commented

Yes, I agree. The media styles that are in place now are basicly created for the newspaper products and they are based on the assumption that the precision grid is used.

One cool thing we could do is that we could add a "hook" for our theme where the theme can declare it's grid sizes. We could then use the definition from the grid to provide the image styles, which is provided by hook_default_image_styles. If we do this, we could basicly generate the appropriate image styles for each grid as long as the theme declare how it should work.

BJ___’s picture

BJ___ CreditAttribution: BJ___ commented

I'm actually building a module that does this very thing (among other things). I have been working on it for a while it's about 60% done. Hopefully it will be done soon

fabsor’s picture

fabsor CreditAttribution: fabsor commented
Status: Active » Postponed

Then I suggest we add that module once it's done and use it as a generic solution.