mindless and others,

I've spent too much time updating the user interface as it is, but I have finally completed what I would like to see become the 2.0 version of Private Message. I'd appreciate any credit going toward the Ubercart project, as this only happened because we really needed this upgraded so our site's PM interface would be up to snuff.

Essentially, I have taken a lot of input into consideration and totally redesigned all the user interfaces. All the Javascript now gracefully degrades. I have incorporated a little more, too, along with an external CSS file to theme some bits of the displays. There is now an actual folder management user interface, and a pseudo-contacts list that lets you message multiple recipients at once. (The autocomplete on message forms works for comma separated lists of usernames, too.) I redid a lot of the menu array so that there are now local tasks that seem intuitive enough. What you're looking at with this code is an almost entirely rewritten/cleaned up version of 1.8. Hence my desire for this to be considered 2.0. The only things I didn't touch were the cron and email parts of the module.

This has been quite a bit of work, and we fully intend to use this at Ubercart. I just don't have time to roll this into a patch myself, and I have no way of getting commit access. So, I'm asking for people to review the code on their own sites or by logging into http://www.ubercart.org and checking it out. I probably won't be making any more modifications personally.

There are no database changes from 5.x-1.8, so you can simply put these files over your current install. Be sure to truncate your cache_menu table so the menu changes take hold. You may want to glance at the configuration settings to make sure they're to your liking. (I added a couple new ones.)

Now it's back into the Ubercode!

Ciao,
-Ryan

Because you can't attach tars and I don't have the time/capability to make this into patches (really, it is a rewrite of all the files involved), please get the code from the following post:

http://www.ubercart.org/forum/announcements/801/site_upgrades

CommentFileSizeAuthor
#32 no_reply.jpg55.69 KBplumwd
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

patrickharris’s picture

Great module! Thanks very much. The menu link "my inbox" (or whatever) appears, even to users who do not have access to private messaging. Shouldn't all the menu callback be placed in a giant if statement?

patrickharris’s picture

Sorry, not an if statement ... the access should take care of it ... I wonder why it isn't working for me.

Boris Mann’s picture

Suggestion: make a 5.x-2.x branch and put this code there. Work can continue on both branches, or at least bug fixes etc. to the 1.x branch, as it gets merged to 2.x.

Make sense?

rszrama’s picture

Aye. I'm not too CVS savvy, unfortunately. I don't understand how to upload the other files and tag them as 2.0 without overwriting the 1.x files. I'm on a Windows box using Smart CVS. Is it simply a subdirectory or is there more to it?

lias’s picture

Hi there and thanks for the updated module. I would like to know since I already have the previous version of privatemsg if I need to disable it and clear out the files or if the update.php script will handle the upgrade?

rszrama’s picture

You can install over the previous version with no difficulty. I haven't modified the database at all, just the user interface and some other settings stuff. : )

You will need to empty (truncate) the cache_menu table in your database to make sure the new menu items are getting set correctly.

lias’s picture

Thank you much for the info. ; )

schnizZzla’s picture

wow, i accidently found this searching google. I'm very excited, gotta test it now. Thanks!

Christefano-oldaccount’s picture

rszrama’s picture

You're right. I'm pretty sure someone reset the URL aliases on that site without telling me. It's causing problems in other areas, too. : (

rszrama’s picture

(I made a page w/ the old URL goto the new page. Thanks for posting that up here.)

dami’s picture

+1 to branch this as 5.x-2.x

fhelmschrott’s picture

great work.

that really should go in as a final 2.0

Is the author not reacting on mails or something?

rszrama’s picture

The original author, TDobes isn't around any more. Contacting doesn't work. mindless has been submitting patches and such, but I don't think he's a maintainer. I don't know exactly how that works. ; )

Boris mentioned making another branch for this version, but I'm not entirely sure how to do that in CVS without overwriting something. If anyone has a clue, I'd be happy to upload the code. (I've got general CVS access for other projects.)

fhelmschrott’s picture

i unfortunately don't know how CVS works but i also tested the module and it looks great so far. Just wanted to translate it but noted that you didn't update the .pot-file. Could you plese do this so translation would be possible. i don't know how to do that :(

dami’s picture

rszrama: Given that mindless can commit patches for this project, he/she most probably could branch as well. You may want to ask to be co-maintainer, so you can make future changes.

+1 to include updated pot file, thanks!

rszrama’s picture

Unfortunately, I don't know how to make .pot files either. I need to figure it out for Ubercart as well, so if anyone call tell me how to do it I'll gladly get it done!

fhelmschrott’s picture

Hey rszrama,

you might want to have a look at drupal.org/translators or http://drupal.org/node/11396

probably that helps. unfortunately i don't know how to generate them so can't help directly.

fhelmschrott’s picture

generally a lot of stuff for contributors (including cvs stuff) can be found here: http://drupal.org/contributors-guide

Luneh’s picture

Category: feature » bug
Status: Needs review » Active

Hi rszrama!

First of all, thanks for the update, the module is now not only useful but really nice-looking and user-friendly.

I do not know where to post this, so I do it here. I have noticed a bug with my contact list. Most of my contacts, coming from my buddylist (module that was installed before the installation of your update) appear in the contact list with their user ID and not a name. In the opposite, the contacts that have already sent me an email are shown with their name.

Do you know why and is it possible to provide a solution for that?

Thanks in advance!

Caroline

rszrama’s picture

Thanks for the encouragement!

Yeah, I don't use the buddylist module, so I didn't get to test that code. It was a simple bug that can be fixed by changing line 1288 to this:

  $contacts[check_plain($buddy->name)] = $buddy->uid;

Thanks for posting it!

NewToDruballer’s picture

Because its not the official 2.0-version, I post it here in the thread. I just found a minor bug: In line 1522 is a letter missing ;-)

drupal_goto('priatemsg');

->

drupal_goto('privatemsg');

Keep up your good work. It's a nice module :thumbup:

Michelle’s picture

The people with commit access on this are:

TDobes http://drupal.org/user/4179
Bèr Kessels http://drupal.org/user/2663
mindless http://drupal.org/user/33033

Looking at the CVS view, it doesn't look like anything's been committed for 3 months. If you don't have any luck getting any of them to respond, try posting an issue requesting to either take over the module or be added as a contributer. I don't know that 3 months would be enough to be considered "abandoned". Depends if mindless has any interest in continuing as he seems to be the only one. I'm pretty sure it's used on Gallery's site, which is why he was active in it.

At any rate, an issue asking to take over would get it decided one way or another.

Michelle

rszrama’s picture

Bug fixed... I certainly don't have the time in the long term to take over the project, but I'll see what I can do to this week to get the code up. Thanks for the suggestions everyone!

csc4’s picture

+1 this sounds like a great enhancement and it would be really great to get it 'official' so update status can monitor it.

spooky69’s picture

Is this code considered stable now and does it include email notification of new messages?

rszrama’s picture

Definitely stable code. :) Been using it at Ubercart.org for a while now without any problems. E-mail notifications haven't been changed between this version and the last, so you can expect them to work the same.

spooky69’s picture

Great, I will have a look at this. I looked further into the issue and it seems the real problem is that email notification of new messages was off by default and there was no way for admin to change the default, at least in the version of privatemsg that I am using. Is this still the case with this code? If so, is there an easy way to change the default?

Thanks for the help and keeping an eye on how Ubercart goes.

kalashari’s picture

Does private message module implements any hooks that other modules can use? For example, a hook when a new message is sent to $user->uid would be nice.

chx’s picture

Version: » 5.x-2.x-dev
Status: Active » Fixed

Comitted, thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)
plumwd’s picture

Title: Private Message Module 2.0 » Failed to reply to message
Status: Closed (fixed) » Active
FileSize
55.69 KB

I'm having issues on my site with this module. When I try to reply to a message, I get a blank page with the number 0 and it does not allow me to reply.

I can create new messages and am notified when I have new messages, but cannot reply.

rszrama’s picture

Title: Failed to reply to message » Private Message Module 2.0
Category: bug » task
Status: Active » Closed (fixed)

Please open a new issue for your problem.

rszrama’s picture

The link above is broken since our site crashed. Please use this one if you're looking for the thread:

http://www.ubercart.org/forum/announcements/163/private_messaging_and_si...

. - dot’s picture

Is this possible for 4.7?

rszrama’s picture

I doubt it... I definitely don't have time for it, and chx has been blazing ahead w/ work on the 2.x branch. There were just too many changes to the module to provide a suitable backport.

Wyze1’s picture

This module is wicked! Thanks for your contribution!

vijayface’s picture

Assigned: rszrama » vijayface
Category: task » feature
Status: Closed (fixed) » Active

Is this possible to send private message to one or more groups.

litwol’s picture

Status: Active » Closed (fixed)

search the modules page please.

http://drupal.org/project/privatemsgmm

vijayface’s picture

Sorry i forgot to mention the version am using drupal 6.4. I need the module that can send the mass messages to OG groups.

vijayface’s picture

i have finished this work..
thanks

vlip’s picture

Version: 6.x-1.x-dev » 5.x-2.x-dev
Status: Closed (fixed) » Needs work

i am using drupal 6.13 and on the RC2 version of 6.* of privatemsg system i am getting the next error in my message inbox,,

error fixed

litwol’s picture

Version: 5.x-2.x-dev » 6.x-1.x-dev
Category: feature » bug

Bug have been fixed long time ago. we are soon going to release rc3 which will encompas the fix. please download 6.x-1.x-dev version for now.

oadaeh’s picture

Version: 5.x-2.x-dev » 6.x-1.x-dev
Assigned: vijayface » Unassigned
Status: Needs work » Closed (fixed)

I'm restoring this issue to its previous states.