Not sure if this is user error or a problem with the module. When I enter overrides into the "Labels and String Overrides" section of the configuration form nothing changes on the search form. For example, setting the Keywords label to "Keywords" still results in "Enter your keywords" on the form. Setting the "Submit button" to "Submit" still results in "Search" on the form. Am I missing something?

CommentFileSizeAuthor
#7 search_config_settings_labels.jpg137.61 KBhermes14
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Alan D.’s picture

Version: 7.x-1.0 » 7.x-1.x-dev
Status: Active » Postponed (maintainer needs more info)

Going to check one thing before looking into this: Are you using user 1 to test? This is a built-in setting from D6 that allows this user to bypass the search overrides which is also implemented in D7.

hermes14’s picture

Same issue here, logged as regular user. I switched to dev version since I noticed this bug in stable.
Actually none of the overrides seems to work. For instance, hiding a content type has no effects at all - the form remains unaltered. The same happens for all of the fields.
If you need more info just let me know, I'll be glad to provide them.

Alan D.’s picture

I switched to dev version since I noticed this bug in stable.

I just tested the submit button string override using 7.x-1.1-beta1 and it worked for me. Is this bug only appearing in 7.x-1.0?

hermes14’s picture

Sorry for the delay. Both 7.x-1.0 and 7.x-1.x-dev show this issue. If 7.x-1.x-dev is actually 7.x-1.1-beta1, then no, it appears also in beta version.
If it works in your installation but not in ours, it may depend on some other modules which probably interfere with it. If so, guessing the right one could be tricky... I'll try with a fresh install and see what happens.

hermes14’s picture

I also tried the 7.x-1.1-beta1 version, which looks pretty much the same as the dev version, if not exactly the same.
Don't know if relevant, but I noticed that the search_config_exclude table remains empty, no matter what I do with the search configuration options. Maybe a clue?

Alan D.’s picture

Could you do a screenshot of your search configuration settings for me so that I can replicate these and test? Only the bottom fieldset with the labels section expanded.

hermes14’s picture

Hope this is what you need. Some parts are translated into italian, sorry...
BTW, I didn't touch anything there, these are the default settings.

Alan D.’s picture

Title: Label overrides provided for fields don't appear to work. » Enable label overrides without requiring other form changes (decouple label overrides)
Status: Postponed (maintainer needs more info) » Active

It is strange that these do not show (note, you need to have the advance form present before the string alters are added). I've never been overly happy with the complexity of the code here, so it will be a good chance to refactor and enforce the string overrides separately. It is near the top of my todo list.

mxh’s picture

any news on this? having the same issue with all versions of this module. installed D7.12.

Alan D.’s picture

Status: Active » Fixed

Yep, done :) Committed into 7.x-1.1-beta2.

mxh’s picture

Alan D., you rock! Many thanks. I will test it next free time and give feedback. Greetings!
Edit: How to setup the module that the settings take effect? Unfortunately, there are still no changes when setting up like "hide this field".

Alan D.’s picture

Are you using user 1 to test? This bypasses the settings. It is a safety fallback from the D6 version in case the module broke something. Find the setting "'Admin bypass (primary user with id 1)" and uncheck this to force the module to skip this check.

Otherwise, if the module is working, fields should be hidden if there is an advanced search form present. Hopefully, I haven't introduced a new bug with the changes.... Which field?

mxh’s picture

sorry for the very late post, but I can report you that it now works. I think there was a settings override problem somewhere with an other module, unfortunately I'm not able to give the exact reason why it didn't work first. Anyway...

Thank your very much for support and for this very useful module!

Greetings

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.