I upgraded to OG 6.x-2.2 and am now getting the following error...

Fatal error: Cannot access empty property in /home/myaccount/public_html/sites/mysite.com/modules/og/modules/og_views/includes/og_views_handler_field_og_invite.inc on line 35

CommentFileSizeAuthor
#7 og.1413312-7.patch622 bytesGrayside
#6 og.1413312-4.patch773 bytesGrayside
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SocialNicheGuru’s picture

i have this issue too.

websitetechnician’s picture

same on the latest version of open atrium (1.2)

SocialNicheGuru’s picture

i had to go through my views and delete og: invite links

Grayside’s picture

This seems quite likely to be a regression related to backing out the upgrade of Notifications 4.x, or otherwise a mysterious bug.

@websitetechnician the error comes from OG 6.x-2.2, which was included in the latest release of Atrium.

SocialNicheGuru’s picture

I upgraded to the latest dev version of og to test and after clearing cache, apc, etc, I still got the WSOD on the pages where the link was

Grayside’s picture

FileSize
773 bytes

Attached patch fixes the problem. It is not, however, a proper solution. I only had a few minutes for now to debug why the alias for nid isn't working, so reverted to what was already working in existing views.

Grayside’s picture

Status: Active » Needs review
FileSize
622 bytes

The attached patch is the correct fix. Just want someone actually seeing this problem to confirm the fix.

The problem was introduced through an under-tested change to the OG Views integration. On the plus side, now that this problem was debugged, you can create invitation links by way of OG Relationships, where before those would have quietly failed.

Status: Needs review » Needs work

The last submitted patch, og.1413312-7.patch, failed testing.

Grayside’s picture

Status: Needs work » Needs review

#7: og.1413312-7.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, og.1413312-7.patch, failed testing.

Ainur’s picture

Subscribe

Grayside’s picture

@Ainur, you know longer need to post to subscribe. Just hit the "Follow" button up near the top of the page.

Grayside’s picture

Status: Needs work » Fixed

Confidant it works, getting bug out of the way.
http://drupalcode.org/project/og.git/commit/c643080

rfay’s picture

Version: 6.x-2.2 » 6.x-2.x-dev

The problem with testing this one was that the branch was set to 6.x-2.2, I would imagine. See http://qa.drupal.org/pifr/test/218758

Grayside’s picture

@rfay why would that be a factor? The tests haven't been changed since 2.2 and bugs should be set to the version in which they appeared...

rfay’s picture

Well, the dependencies are quite different, at least as listed. But regardless... patches should always tested against dev in every project. That's what they'll be applied to.

Grayside’s picture

Dependencies did not change at all. That was a puzzlement on it's own. I'll take this up in #1419530: OG6 Language Tests Failing

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

pfournier’s picture

Status: Closed (fixed) » Needs work

A similar patch should be applied to og_views_handler_field_og_is_admin.

All views handlers using $this->aliases['nid'] in render() should also have something like:

function construct() {
    parent::construct();
    $this->additional_fields['nid'] = array('table' => 'node', 'field' => 'nid');
  }

  function query() {
    $this->ensure_my_table();
    $this->add_additional_fields();
  }
Grayside’s picture

Status: Needs work » Closed (fixed)

Please create a new bug report. Referencing this issue would be a good idea :)

memcinto’s picture

Same issue, og_views_handler_field_og_is_admin, 6.x-2.4. Took a peek at the latest dev and the code in this include has not changed.

Error occurs when you try to add the field "Organic groups: OG: Is member an admin in a group" to a View.

Fatal error: Cannot access empty property in [site file path]/modules/og/modules/og_views/includes/og_views_handler_field_og_is_admin.inc on line 19

memcinto’s picture

Sorry, inadvertently created duplicate comment.

pfournier’s picture