Allow group members to view unpublished group content [#1414002]

Problem/Motivation

There is (to my knowledge) currently no way to allow group members to view unpublished content within their group(s).

Many of the workflow modules (e.g. Workflow, Workbench Moderation etc) work by publishing and unpublishing nodes. In order to effectively use these modules in combination with OG, there needs to be a way to grant view access to unpublished group content.

Proposed resolution

Add a new global OG permission called "View unpublished group content".

Remaining tasks

Currently unknown.

User interface changes

As previously descibed, add a new permission in the golbal permissions screen.

API changes

Currently unknown.

Comment	File	Size	Author
#2	og-view-unpublished-1414002.patch	1.38 KB	shenzhuxi
#2
#1	og-view-unpublished-1414002.patch	1.38 KB	shenzhuxi
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

shenzhuxi CreditAttribution: shenzhuxi commented 1 February 2012 at 16:26

File	Size
og-view-unpublished-1414002.patch	1.38 KB

this patch only work for 7.x-1.3.
7.x-1.x was already quit different.

Comment #2

shenzhuxi CreditAttribution: shenzhuxi commented 1 February 2012 at 16:26

File	Size
og-view-unpublished-1414002.patch	1.38 KB

this patch only work for 7.x-1.3.
7.x-1.x was already quit different.

Comment #3

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 5 February 2012 at 09:54

Status:

Active

» Needs review

Setting correct status.

Comment #4

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 5 February 2012 at 09:55

Can you re-roll it against 2.x and 1.x -dev versions?

Comment #5

5 February 2012 at 09:56

Status:

Needs review

» Needs work

The last submitted patch, og-view-unpublished-1414002.patch, failed testing.

Comment #6

shenzhuxi CreditAttribution: shenzhuxi commented 6 February 2012 at 10:31

Please check this patch
http://drupal.org/node/1425824#comment-5564130

Comment #7

bonobo CreditAttribution: bonobo commented 24 September 2012 at 18:17

Amitai - are you still looking for a 2.x version of this? We are running into this, and could roll a patch if this is something that still is of interest.

Comment #8

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 24 September 2012 at 18:31

Version:

7.x-1.3

» 7.x-2.x-dev

@bonobo,

Yes, lets get it in, it can help with workflows. Also it would be nice to cover it also in OG-access.

Comment #9

bonobo CreditAttribution: bonobo commented 25 September 2012 at 18:24

Does it make sense for this to be part of OG, or should we let something like OG Moderation handle this?

Comment #10

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 25 September 2012 at 19:18

Oh, forgot about OG-moderation, yeah it should probably go there.

Comment #11

StephenRobinson CreditAttribution: StephenRobinson commented 2 October 2013 at 16:04

Made a simple patch to og.module:

/**
 * Implement hook_node_access()
 */
function og_node_access($node, $op, $account) {
  $type = is_string($node) ? $node : (is_array($node) ? $node['type'] : $node->type);
  $status=1;
  if(isset($node->status)){
    $status=$node->status;
  }
  // if (in_array($op, array('update', 'delete'))) { // removed 
  if ((in_array($op, array('update', 'delete'))) || ($status==0 && $op=='view' && $type=='group') ) {

Comment #12

StephenRobinson CreditAttribution: StephenRobinson commented 25 October 2013 at 08:53

had to fix this in 2.3 as well....

/**
 * Implements hook_node_access().
 */
function og_node_access($node, $op, $account) {
  $type = is_string($node) ? $node : (is_array($node) ? $node['type'] : $node->type);
 + $status = is_string($node) ? $node : (is_array($node) ? $node['status'] : $node->status); // added
.
.
.
-  elseif (in_array($op, array('update', 'delete'))) {
+  // elseif (in_array($op, array('update', 'delete'))) { // removed
+  elseif ((in_array($op, array('update', 'delete'))) || ($status==0 && $op=='view' && $type=='group') ) { // added