The problem is that you are manually trying to grab the field instance settings out of $form_state, but there is a helper function that does this for you.

link.module seems to do this correctly (now). You might want to check if there are any other fixes in that function that you want to take over, but my change does atleast fix this bug.

CommentFileSizeAuthor
html5_tools_field_widget_instance.patch950 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ericduran’s picture

Status: Needs review » Fixed

Makes perfect sense. I'm opening up a followed up issue to see if the link module has changes anything aslo to double check this is still required.

Thanks.

--
http://drupalcode.org/project/html5_tools.git/commit/bd36a5d

ericduran’s picture

@Berdir, FYI, I just push a change to completely change all this. The issue is #1415578: Follow up on the Link Module and you can see the diff over at http://drupalcode.org/project/html5_tools.git/blobdiff/bd36a5deb27d45bd4...

Essentially I stop replacing the link fields process callback. I honestly don't remember why I did that. But it seems unnecessary. Instead I just added another callback and modified what I wanted to change. Which makes the code a lot more manageable and simpler.

Thanks again for the issue :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.