Servus, folks.
First of all, thanks for the great work on Simplenews -- I really got to like how it works. Only recently I made quite some progress in theming newsletters sent out through Drupal and it's really a wonderful system by now. However, there's one (minor) issue which limits the use of Simplenews considerably:
Given there are three different mailing lists, Zone A, Zone B, and Zone C.
Usually, individual newsletters are written for each Zone. But when I want to mail the same newsletter to all of those Zones, I'm stuck.
I couldn't find a way to change the target list once mail has been sent, and I haven't found a way to mark more than one list for sending.
So far I solved the issue by copying the content to a newly created newsletter manually, but this only works well if everything is just in the "body" field. Using dozens of specialized field doesn't fit this workflow well… Possibly I could use some sort of node copying module, but I wonder if it weren't way easier to make that "address list" field a multi-select control to chose more than one list per newsletter …
Please let me know what you think or if there's workaround for this issue.
Thanks, Norbert
Comment | File | Size | Author |
---|---|---|---|
#19 | multiple_categories_simplenewslettre_7.x.1.x.diff | 1.99 KB | arunkumark |
#16 | multiple_categories_simplenewslettre_7.x.1.x.diff | 1.87 KB | arunkumark |
Comments
Comment #1
miro_dietikerThat's indeed a feature that is missing.
I think it was already requested multiple times..
Note that implementing this feature would require quite an amount of work. So anyway, don't expect it for current D7 branch...
And if you like to push it to show up, hire someone to make a suggestion. I'm open for discussions about how to implement this preferrably and provide you insights about previous discussions about this possible feature.
Comment #2
nofue CreditAttribution: nofue commentedThanks for your reply - and as much as I'd like a chromed version, I'd be happy with just a hack ;)
Maybe a means to change the list once the list has been sent?
Right now you can edit every field once a Newsletter has been sent, except for the 'List' Field...
Regarding multiple selections - how hard can it be to write a loop calling the mail processing
However - I have some money at hand -- anybody willing to make this miracle come to happen - for drupal 6, as I still miss much needed modules on 7...
Comment #3
miro_dietikerSwitching versions.
Feature requests no more allowed for 6.x versions.
Comment #4
nofue CreditAttribution: nofue commentedMy clients run on 6.x until critical modules are available with 7.x and I'm going to pay for that fix of Simplenews on 6.x if anybody is willing to jump in.
Comment #5
BerdirFeature requests can't be major/critical by definition :)
Note that this is *not* a trivial change, it requires quite some changes to the current code and the database structure.
Comment #6
MastaP CreditAttribution: MastaP commentedDid I understand that it is impossible to send a single newsletter to multiple categories?
Because by doing it one by one, each receives as many copies as categories they are registered to. yaiiks. :/
Is there a solution coming up for this? How can we help?
thanks! :)
Comment #7
BerdirThis is currently not supported, correct. This current architecture doesn't allow it. This will be revisited for the 7.x-2.x branch but don't expect anything for 7.x-1.x
Comment #8
Breakerandi CreditAttribution: Breakerandi commentedBy the Way, without this option there is duplicate content, which is not good for SEO.
I Have also a little money to make this happen for 7.x-2.x
Comment #9
MastaP CreditAttribution: MastaP commentedI do too have a little money for this to move forward. :)
Comment #10
miro_dietikerDuplicated by #2115743: Send a newsletter to all subscribers of more then one newsletter
Which even contains code against 6.x-2.x
Comment #11
PROMESI think to implement the feature is not so hard with my code at hand in issue #2115743.
I am sorry, I have been looking for an existing issue, but I couldn't find this one.
Comment #12
XoRDy CreditAttribution: XoRDy commentedI've fixed it for 7.x-2.x-dev
https://drupal.org/node/2153579
Comment #13
arunkumarkHi,
Below patch worked for me. In our Field configuration need to change simplenewsletter category type Radio to Checkbox Simple newsletter and check required categories to send the newsletter.
In patch am changed query for getting users list as IN clause in condition instead of WHERE clause.
Thanks & Regards
Arunkumar K
Comment #14
arunkumarkComment #15
luscomusco CreditAttribution: luscomusco commentedHi, thanks for your patch
I just test it,
I changed Number of values of field_simplenews_term to "unlimited" but now I can,t save newsletter now
if checked more then one category i got "Only one newsletter category term is allowed." error
What else must be done
Thanks & Regards
Comment #16
arunkumarkHi luscomusco,
Thanks for immediate response i re-patched to overcame this issue please check new patch.
Thanks & Regards
Arunkumar K
Comment #17
luscomusco CreditAttribution: luscomusco commentedHi, arunkumark , thanks for fast work
I repatched, but here is another issue
when send button is hit, nothing happens
and here is the logg
Notice: Undefined index: und in simplenews_add_node_to_spool() (line 24 of /home/techtjvh/public_html/tehko2015/sites/all/modules/simplenews/includes/simplenews.mail.inc).
Warning: Invalid argument supplied for foreach() in simplenews_add_node_to_spool() (line 24 of /home/techtjvh/public_html/tehko2015/sites/all/modules/simplenews/includes/simplenews.mail.inc).
Notice: Undefined variable: tids in simplenews_add_node_to_spool() (line 35 of /home/techtjvh/public_html/tehko2015/sites/all/modules/simplenews/includes/simplenews.mail.inc).
Warning: Invalid argument supplied for foreach() in DatabaseCondition->compile() (line 1853 of /home/techtjvh/public_html/tehko2015/includes/database/query.inc).
Thanks & Regards
Comment #19
arunkumarkThanks luscomusco, for checking and point out exact issue. again i re-patched and make generic to support all languages. Before that i made a problem in Language undefined(und) in code.
Thanks & Regards,
Arunkumar K
Comment #20
luscomusco CreditAttribution: luscomusco commentedGreat job arunkumark
it works
Thanks & Regards,
i think this must be in core of simplewnews module
Comment #21
luscomusco CreditAttribution: luscomusco commentedComment #22
luscomusco CreditAttribution: luscomusco commentedComment #23
PascalAnimateur CreditAttribution: PascalAnimateur commentedThe patch in #19 might allow multiple newsletter categories per simplenews node, but the real problem is preventing the same recipient (subscribed to multiple lists) from receiving multiple copies of the same newsletter issue! This is what @Berdir was referring to in #7 if I'm not mistaken...
It does work really well in 2.x though, a version which should receive more attention IMHO.
Comment #24
arunkumark@PascalAnimateur thanks to your comment, the patch won't allow the newsletter module send multiple mails to individual users. It take distinct user mail id from simplenewsletter subscription table. Also you can view number of subscribers in for created newsletter, it removes repeat mailid values.
Thanks & Regards
Arunkumar K
Comment #25
AnybodyI can confirm the patch works great and make the situation better than before. The point from #23 should be documented but I think that's a topic for 7.x-2.x.
Please add this patch to the next dev release of 7.x-1.x
Comment #26
xaffimarc CreditAttribution: xaffimarc commentedHi chaps,
I have applied the patch from #19 to 7.x-1.1.
However, I am noticing that it is only sending to the first selected list (as in first listed), regardless of how many are picked.
Currently this patch doesn't work IMHO. Is anyone able to confirm this issue for me?
Thanks
Comment #27
michal.k CreditAttribution: michal.k commentedHello,
I've chosen different approach, maybe it would be helpful for someone:
1. One Newsletter Category
2. Same field on node type and user with Newsletter Subcategories.
3. Use hook_simplenews_spooled() to remove users if there is no field Newsletter Subcategory intersection.
KR,MK.
Comment #28
wylbur CreditAttribution: wylbur at Electric Citizen commentedComments above indicate that is is not working as intended, so changing this to needs work for now.
Will try to test and confirm if it is not working.