I tried to integrate the module into linkchecker... Added 1000 urls from d.o into httprl_request()... We need to solve #1268096: Implement a rate limiter asap.

Incomplete responds array:
2012-01-28_145332.png

I guess my action killed my local server I fired the stuff, too.

So what's the problem?

  1. Status == "Done"
  2. Code is missing. Really need this value!
  3. Status_message is missing.

Comments

Issue summary:View changes

Embedded link is defect

Issue summary:View changes

foo

Priority:Normal» Critical

I've seen one more variant where the "error" and "code" was below "request". This means $foo->request->error and $foo->request->code and missing in root of Class. It must always be $foo->code and $foo->error. $foo->code is required in all cases, error is optional.

Issue summary:View changes

fff

StatusFileSize
new20.54 KB

Example dump for #1 bug

2012-01-29_032521.png

Added 2 lines (Line 350ff) in function httprl_send_request(): $result->code and $result->error

<?php
   
// Connection was never made.
   
else {
     
$result->status = 'Connection not made.';
     
$result->code = (int) $request->code;
     
$result->error = $request->error;
     
$counter++;
      return
FALSE;
    }
?>

Title:Responds array incomplete / inconsistentResponds object incomplete / inconsistent
Status:Active» Needs review
StatusFileSize
new592 bytes

Patch for #4. It does not fix the redirect inconsistency bug(s).

Re-attach patch with changed name as %2F cause problems on d.o. The (int) is there as it seems to be possible that this is sometimes not an int what is not allowed, but I've seen it... no idea why.

With more thinking it may be better to refactor/review the full logic to prevent such consistencies in general. What i've done here was a quick fix that may break in other situations... Not sure.

Status:Needs review» Fixed
StatusFileSize
new1.31 KB

Pushed the casting to an INT higher up in the code. Patch below committed to 6.x & 7.x.

Does this also fix the "redirect" inconsistencies compared to core?

I think it might, only one way to find out ;)
#1320222-3: Bring in other drupal patches

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

foo