Even if a user has the access webform reports, she can't access the listing page admin/content/webform_report.

I noticed that in the implementation of hook_menu, the argument passed to the user_access function (which is the access callback) is administer site configuration. I find that inconsistent with the naming of the permissions.

In the _webform_report_page function, the access webform reports permission is checked, but then it's too late for users without the administer site configuration permission.

Unless I'm overlooking something, I think that the access webform reports should control the access to the listing, and the edit and delete links should appear only for users that have edit permission over the node.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

noel.rivas’s picture

Proposed solution.

noel.rivas’s picture

Title: Users with access webform reports can't list reports » Review?
Status: Active » Needs review

Forgot the status change!

noel.rivas’s picture

Title: Review? » Users with access webform reports can't list reports