The openlayers module gives a javascript error in Chrome and in Safari when it is used with the twitter widget from www.twitter.com.

I have added a patch with the javascript fix for this.

I am not sure which component to use for this issue.

Thanks,
Jaap Jansma

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

Status: Active » Needs work

Indeed, a very valid concern and the right fix.

You can take out the comment, proper attribution will be given through git. in your patch the variable 'i' is not declared and leak to the global namespace. please use for (var i = 0, il = newBlabla.length; i…).

If you could name your patch properly too, that would be nice.

Almost there :)

mgifford’s picture

Is this really against OL3 or is it really OL2? Agreed about the comments. They need to be removed.

jaapjansma’s picture

Hereby a new patch.
This patch belongs to version 7.x-2.x-dev of the Openlayers Module. Could not figure out which openlayers version is used in that module.

jaapjansma’s picture

Status: Needs work » Needs review
FileSize
507 bytes

I have removed the comments as well from the patch.

Status: Needs review » Needs work

The last submitted patch, openlayers-twitter-conflict-1421352-1.diff, failed testing.

mgifford’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, openlayers-twitter-conflict-1421352-1.diff, failed testing.

m.stenta’s picture

Issue summary: View changes
Status: Needs work » Closed (cannot reproduce)

This patch no longer applies against the 7.x-3.x branch. A lot has changed since this issue was posted, so it's possible that it's no longer an issue. Please reopen with an updated patch if it still is. Thanks!