Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The openlayers module gives a javascript error in Chrome and in Safari when it is used with the twitter widget from www.twitter.com.
I have added a patch with the javascript fix for this.
I am not sure which component to use for this issue.
Thanks,
Jaap Jansma
Comment | File | Size | Author |
---|---|---|---|
#4 | openlayers-twitter-conflict-1421352-1.diff | 507 bytes | jaapjansma |
#3 | openlayers-twitter-conflict-1421352-1.diff | 991 bytes | jaapjansma |
patch.diff | 987 bytes | jaapjansma | |
Comments
Comment #1
nod_Indeed, a very valid concern and the right fix.
You can take out the comment, proper attribution will be given through git. in your patch the variable 'i' is not declared and leak to the global namespace. please use
for (var i = 0, il = newBlabla.length; i…)
.If you could name your patch properly too, that would be nice.
Almost there :)
Comment #2
mgiffordIs this really against OL3 or is it really OL2? Agreed about the comments. They need to be removed.
Comment #3
jaapjansma CreditAttribution: jaapjansma commentedHereby a new patch.
This patch belongs to version 7.x-2.x-dev of the Openlayers Module. Could not figure out which openlayers version is used in that module.
Comment #4
jaapjansma CreditAttribution: jaapjansma commentedI have removed the comments as well from the patch.
Comment #6
mgifford#4: openlayers-twitter-conflict-1421352-1.diff queued for re-testing.
Comment #8
m.stentaThis patch no longer applies against the 7.x-3.x branch. A lot has changed since this issue was posted, so it's possible that it's no longer an issue. Please reopen with an updated patch if it still is. Thanks!