#1415788: Javascript winter clean-up

Replace $element[check ? 'addClass' : 'removeClass']('classname'); with $element.toggleClass('classname', check);, same for show/hide.

CommentFileSizeAuthor
#4 core_js_jquery_toggle-1428538-d7-4.patch1.4 KBAlbert Volkman
core-js-jquery-toggle.patch1.45 KBnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs review » Reviewed & tested by the community

cleaner code

droplet’s picture

droplet CreditAttribution: droplet commented
Issue tags: +Needs backport to D7
Dries’s picture

Dries CreditAttribution: Dries commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 8.x. Patch will need a re-roll for 7.x so moving to 7.x with the 'to be ported' status.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
Status: Patch (to be ported) » Needs review
FileSize
core_js_jquery_toggle-1428538-d7-4.patch1.4 KB

D7 re-roll!

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

Works for me, thanks :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks for all of these nice JS clean-up patches!

Automatically closed -- issue fixed for 2 weeks with no activity.