Create a 6.x-2.x version to work with jPlayer 2.0 [#1428836]

I am still on Drupal 6, but would like to use the jPlayer 2.0 version, which currently does not work.

So, I would like to see a 6.x-2.x version that supports the new version.

I will look at this myself if i get time, but wanted to create this issue in case any one else has looked into it. What exactly are the major differences in how the module should work.

http://jplayer.org/latest/release-notes/

Comment	File	Size	Author
#3	jplayer-1428836-jplayer-2.x.patch	117.88 KB	smoothify

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

deviantintegral CreditAttribution: deviantintegral commented 16 February 2012 at 15:48

I'm not directly familiar with the differences between the two versions of jPlayer as I didn't do the initial D7 port. But, I'd see this as being a great opportunity to unify the two sets of JS code. So, I'd guess any such upgrade would involve a few patches to the D7 version as well.

Comment #2

mwsam CreditAttribution: mwsam commented 24 February 2012 at 22:06

I'm currently working on this, the fork is at https://github.com/mwsam/jplayer. Contribution welcomed.

I intend to provide a patch file to the original 6.x-1.x branch of this module once the code is working and usable.

Comment #3

smoothify CreditAttribution: smoothify commented 26 February 2012 at 23:30

Status:

Active

» Needs review

File	Size
jplayer-1428836-jplayer-2.x.patch	117.88 KB

Here is a patch comprising of the work I commissioned mwsam to do to get jplayer 2.x working with Drupal 6.x.

This should be applied against the 6.x-1.x branch, but due to the nature of the changes a new 6.x-2.x branch should be created. (I would be happy to maintain this). It's a large patch, to see the individual changes you can also look here : https://github.com/mwsam/jplayer/commits/6.x-1.x

This is a partial backport of the 7.x-2.x branch, keeping as close to the same code and functionality as possible. Some things weren't possible in D6, such as allowing field formatter settings, so we went for allowing site-wide defaults, and the player settings can be overridden in a template_preprocess function.

I have tested this and it works well for me, both in single file and playlist, in html5 and flash forms. The one requirement, apart from having the jPlayer 2.0 library, is a recent version of jQuery. I had errors when using jQuery 1.3.x supplied by default with jQuery_update, but when I used 1.7.x it worked well. I'm not sure where the cutoff version is, most likely though its 1.4.x.

Now, currently out of the box, jquery_update has some problems with 1.7.x, you can see the progress here: #1067290: Fix jQuery 1.7 for Drupal 6. I have a github repository containing a working version, that is what we used to test this patch. https://github.com/smoothify/jquery_update

Comment #4

Bensbury CreditAttribution: Bensbury commented 8 April 2012 at 07:59

Hi,

Any news on the D6 update as we have a need to use the jump to time ability in the 2.0 api's play function.
The 1.2 version doesn't allow this.

Did the patch get accepted and if so will it be going in?

Thanks

Comment #5

smoothify CreditAttribution: smoothify commented 8 April 2012 at 09:46

Perhaps you could test it out and see if it works for you. That would help the maintainer if other people review it.

Comment #6

Bensbury CreditAttribution: Bensbury commented 9 April 2012 at 03:35

Might give it a try, although it's for a production site right now, and I found out what I needed to do by discovering the 1.2 api documentation.
If anyone needs that it is here:

http://www.jplayer.org/1.2.0/developer-guide/

Going to 2.0 is still preferable though.

Comment #7

hedac CreditAttribution: hedac commented 8 May 2012 at 10:46

hope to see jplayer2 support for 6.x drupal since many many websites still use drupal 6
I'll try that patch...

Comment #8

thermalmusic CreditAttribution: thermalmusic commented 24 October 2012 at 18:09

I tried applying jplayer-1428836-jplayer-2.x.patch to jplayer module 6.x-1.0-beta4 but get the output message:

malformed patch at line: 1599 laylist div.jp-playlist li {

I'm using unixutils patch command on winxp, running apache2 and php 5.2
Any ideas?
Thanks

Comment #9

hargobind

he/him

Austin, Texas

CreditAttribution: hargobind commented 5 March 2015 at 06:21

Issue summary:	View changes
Status:	Needs review	» Reviewed & tested by the community

I realize it's been a few years since @smoothify and @mwsam created the 6.x-2.x fork of this project, so this review might no longer be useful. But considering that jPlayer 1.x has been deprecated and taken offline (for security reasons) in favor of the 2.x branch, I wanted to give this fork a try.

Although the attached patch doesn't work for me using the patch tools in TortoiseGit (Windows), I was able to download it direct from GitHub and it seems to work like a charm. I tested out many of the options on the settings page and everything seems to be working as expected with the latest version of jPlayer (2.9.2). Great job @mwsam!