Tests for 'status' in where clause is ambiguous

For what it's worth, this seems similar to
http://drupal.org/node/1430386

Bugs get fixed in 8 first then backported.
If the patch works for you, please mark the ticket as 'reviewed and tested by the community'.
Then after committed, we'll get the D7 backport.
Regarding invalid argument supplied for foreach() in forum_menu_local_tasks_alter() - there is an existing ticket for that - see #1157142: Watchdog: Undefined index: node in forum_menu_local_tasks_alter() (line 175 of ../forum/forum.module.

After applying patch #3 I get this:

PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'node.tid' in 'on clause': SELECT f.tid AS tid, COUNT(n.nid) AS topic_count, SUM(ncs.comment_count) AS comment_count FROM {node} n INNER JOIN {node_comment_statistics} ncs ON n.nid = ncs.nid INNER JOIN {forum} f ON n.vid = f.vid INNER JOIN {node} node ON f.tid = node.tid WHERE (n.status = :db_condition_placeholder_0) AND (n.language IN (:db_condition_placeholder_1, :db_condition_placeholder_2)) GROUP BY tid; Array ( [:db_condition_placeholder_0] => 1 [:db_condition_placeholder_1] => en [:db_condition_placeholder_2] => und ) in forum_forum_load() (line 780 of /modules/forum/forum.module).

#3: 1431452-ambiguos-status.patch queued for re-testing.

Drupal 7.12 when visiting my site http://mysite.com/forum

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'status' in where clause is ambiguous: SELECT f.tid AS tid, COUNT(n.nid) AS topic_count, SUM(ncs.comment_count) AS comment_count FROM {node} n INNER JOIN {node_comment_statistics} ncs ON n.nid = ncs.nid INNER JOIN {forum} f ON n.vid = f.vid INNER JOIN {node} node ON f.tid = node.tid WHERE (status = :db_condition_placeholder_0) AND (n.language IN (:db_condition_placeholder_1, :db_condition_placeholder_2)) GROUP BY tid; Array ( [:db_condition_placeholder_0] => 1 [:db_condition_placeholder_1] => vi [:db_condition_placeholder_2] => und ) trong advanced_forum_forum_load() (dòng 142 của /var/www/clients/client1/web29/web/sites/all/modules/advanced_forum/includes/core-overrides.inc).

Drupal 7.12 when visiting my site http://mysite.com/forum

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'status' in where clause is ambiguous: SELECT f.tid AS tid, COUNT(n.nid) AS topic_count, SUM(ncs.comment_count) AS comment_count FROM {node} n INNER JOIN {node_comment_statistics} ncs ON n.nid = ncs.nid INNER JOIN {forum} f ON n.vid = f.vid INNER JOIN {node} node ON f.tid = node.tid WHERE (status = :db_condition_placeholder_0) AND (n.language IN (:db_condition_placeholder_1, :db_condition_placeholder_2)) GROUP BY tid; Array ( [:db_condition_placeholder_0] => 1 [:db_condition_placeholder_1] => vi [:db_condition_placeholder_2] => und ) trong advanced_forum_forum_load() (dòng 142 của /var/www/clients/client1/web29/web/sites/all/modules/advanced_forum/includes/core-overrides.inc).

Committed to 7.x and 8.x.

http://drupal.org/node/1437932

Its not committed to 7.x. I rolled a patch for d7.

Go testbot!

Go testbot!

The patch name must not end in -D# if you want testbot to queue it :)

Thanks :)

woho.

Getting this too after applying patch #3 :

PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'node.tid' in 'on clause': SELECT f.tid AS tid, COUNT(n.nid) AS topic_count, SUM(ncs.comment_count) AS comment_count FROM {node} n INNER JOIN {node_comment_statistics} ncs ON n.nid = ncs.nid INNER JOIN {forum} f ON n.vid = f.vid INNER JOIN {node} node ON f.tid = node.tid WHERE (n.status = :db_condition_placeholder_0) AND (n.language IN (:db_condition_placeholder_1, :db_condition_placeholder_2)) GROUP BY tid; Array ( [:db_condition_placeholder_0] => 1 [:db_condition_placeholder_1] => en [:db_condition_placeholder_2] => und ) in forum_forum_load() (line 780 of /modules/forum/forum.module).

Putting it back how it was

Hm. I committed and pushed this to 7.x to get us parity with 8.x, however...

Why was this error not caught by our existing forum tests? We need the tests expanded so they would catch this in the future, because we /did/ run the full test suite against that security patch before it went in.

These issues only show up when a contrib module uses the query_alter() hook and joins in some more table.

I think the proper fix for this would be improving the query builder so it adds a table alias to every field in the query, this would me much more friendly with modules implementing query alter hooks.

The Internationalization related issue has been fixed, btw, #1437932: Multilingual select 7.x-1.4 module cause PDOException on drupal forum
Before joining in any other table, we are now adding table alias for fields without one when possible, that is if there's a single table.

Ah, thank you @Jose Reyero! I was at a loss for how to reproduce this. So actually this is not a core bug at all; it is a bug with the module adding the query alter, and this should be reverted in core, perhaps in favor of a more complete solution for table aliasing generally.

Can you provide an example of a module that causes the issue?

I don't think the extra specificity in the core query really harms anything. But it indeed sounds like as far as core's concerned, there's nothing more to do here. We don't need tests to show how well we babysit broken code.

Unfortunately, the mentioned patch failed to meet dependancies with me:

error: while searching for:
dependencies[] = i18n_node
package = Multilingual - Internationalization
core = 7.x


error: patch failed: i18n_forum/i18n_forum.info:5
error: i18n_forum/i18n_forum.info: patch does not apply
Checking patch i18n_forum/i18n_forum.test...
Checking patch i18n_select/i18n_select.module...

Working with latest version of Drupal (7.12) and i18n module (7.x-1.4) as well, and all multilingual modules enabled.
So, is it acceptable to change status to 'needs work' (as patch mentioned in topic didn't work either - see comment #6)?

@Bitbull -- The patch was committed to Drupal core, not i18n. If there's an issue with i18n, you should file it in that module's queue. Thanks!

@xjm -- I was actually replying to comment #21, stating that http://drupal.org/files/i18n-clean_select_api-1437932-25.patch repaired the problem. And as the versions match with mine (latest at this very moment) and the patch stated in #21 fails to apply on my installation (see output on comment # 26), and that the patch submitted in this topic (#17) throws the problem mentioned in #20, I unfortunately have still no solution to the problem ...

Please follow up in the i18n issue, which is where that patch is from. #1437932: Multilingual select 7.x-1.4 module cause PDOException on drupal forum.