This would allow the characteristics of this link to be changed by modules, themes, etc. based on more specific requirements.

This will also help:
#347698: change 'Join' link to 'Login to join'
#215276: Adding link to OG Block Menu when Group is in Moderation
maybe #1372346: Customized member invitation based on user type

Files: 
CommentFileSizeAuthor
#6 og-theme_subscribe_link-1432016-4.patch2.83 KBgoron
PASSED: [[SimpleTest]]: [MySQL] 266 pass(es).
[ View ]
#3 og-theme_subscribe_link-1432016-3.patch3.2 KBgoron
PASSED: [[SimpleTest]]: [MySQL] 266 pass(es).
[ View ]
#1 og-theme_subscribe_link-1432016.patch3.16 KBgoron
PASSED: [[SimpleTest]]: [MySQL] 266 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new3.16 KB
PASSED: [[SimpleTest]]: [MySQL] 266 pass(es).
[ View ]

Here's a patch

Status:Needs review» Needs work

First line of function documentation should always be a one-liner description of what the function does, followed by an empty line, followed by additional text as needed, then parameters. @deprecated should be placed below the @param/@return items.

StatusFileSize
new3.2 KB
PASSED: [[SimpleTest]]: [MySQL] 266 pass(es).
[ View ]

Moved @deprecated.

Status:Needs work» Needs review

Status:Needs review» Needs work

Don't know how I missed it.

og_subscribe_link() should simply be a wrapper around theme('og_subscribe_link').

Status:Needs work» Needs review
StatusFileSize
new2.83 KB
PASSED: [[SimpleTest]]: [MySQL] 266 pass(es).
[ View ]

Ha. Oops.

Updated patch.

Status:Needs review» Reviewed & tested by the community

Want to give this a little time to attract a second opinion.

Probably

This function is deprecated in favor of theme_og_subscribe_link() => This function is deprecated in favor of theme('og_subscribe_link'

As don't want people calling theme_og_subscribe_link directly.

Status:Reviewed & tested by the community» Needs work

Good point.

Status:Needs work» Fixed

http://drupalcode.org/project/og.git/commit/739ed8a

Committed with slight change.

The @deprecated tag marks that the original og_subscribe_link() function is not advised, and will be dropped after a couple releases.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.