This minor bug affects Webform when used with the Form Builder project. The Form Builder project allows fieldsets to toggle the display of the #title property on or off. But unfortunately if we set #title = NULL in the Webform form rendering, Form Builder will discard the title entirely, rather than keeping the title stored but not displaying it. Drupal 7 does not actually support the #title_display property on fieldsets at all, which makes this situation a bit more sticky.

This set of patches makes it so that both D6 and D7 support hiding the fieldset title by using a #pre_render function. D6 had already been using this #pre_render function for fieldsets (and other fields), so the patch is smaller for it, but the pre_render function is re-introduced into the D7 version exclusively for fieldset usage.

This patch also contains some small changes related to title display that were causing an issue on my local, which result in replace "==" operators with strcmp(), which is recommended by php.net anyway for string comparison.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

Status: Needs review » Fixed

Committed to both branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.