Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This is a great module and I love the simplicity. I would love to be able to add an icon for an RSS feed that is not hosted on the Drupal site with this module.
Thank you,
Eric
Comment | File | Size | Author |
---|---|---|---|
#4 | rssfix-1432746-4.patch | 1.52 KB | tgeller |
Comments
Comment #1
jenlamptonHm. It would be possible to allow configuration of the RSS icon/link, I'll see about including this in the next version. Thanks for the suggestion :)
Comment #2
juliangb CreditAttribution: juliangb commentedAlso keen on this feature - so that I can easily link to a RSS feed provided by views.
Comment #3
tgeller CreditAttribution: tgeller commentedI see this never made it in. Pretty please?
Comment #4
tgeller CreditAttribution: tgeller commentedHOLY CRAP I FIXED IT. This is my first-ever real code contribution to contrib.
I left in comments, which could (and should) be removed. Jen?
Comment #5
jenlamptonThanks Tom!
It looks like this patch removes the intended (default) behavior that linked the RSS feed icon to the site's rss feed(s) and turns it into an "ordinary service". :)
Although that might work for your use case (and everyone else in this issue) most people using OTW and it's RSS icon would probably prefer not to have to enter in data Drupal already knows ("where is my RSS feed?"). I'd prefer if the option to define a feed were optional, so changing status to "needs work" so we don't loose existing functionality. (but for those who need it, please continue to use this patch!)
I'd like to do an overhaul of the settings form anyway, provide a checkbox for each available service, and use #states to show the URL fields only when the box is checked. Once that is done adding a second checkbox for "Use Drupal's internal RSS feed" that is checked by default for RSS should be a sinch.:)
Edit: see #1953620: Overhaul the block/panels pane config form
Comment #6
tgeller CreditAttribution: tgeller commentedHi, Jen -- thanks for your fast response. At this point I'll have to leave the coding to someone else. I am bear of little brain.
Although I fully support the idea of making the RSS path field optional, I disagree somewhat that:
A site can have many RSS feeds, for blogs, product releases, news, etc.. Drupal can't know which is the important one to feature in a (persistent) block!
But again, I like the idea of making this a two-mode setting: 1) a checkbox for times where there's an obvious feed that Drupal can detect, and 2) a text field for other times.
Comment #7
jenlamptonThere is rarely more than one RSS feed per page, so if the cache settings are DRUPAL_CACHE_PER_PAGE I think Drupal can continue to use it's magical drupal_get_feeds() function to link to the RSS feed icon to the feed on the current page.
I'm looking at this from the perspective of someone who wants to subscribe via RSS to "a site". They will almost always want the feed for the page they are on ("this blog" or "this product" or "this list of news articles", not some global site-wide feed) unless, of course, that particular page does not have a feed of it's own.
and when that's checked, we show radios:
when the fist option is checked (it will be checked by default)
Edit: The UI for this is getting rather complex (not to mention the code to drive it), and I'm now thinking that maybe letting people choose a single RSS feed for this block will be easier than my give-the-people-what-they-want approach, and this issue has been open for too long to strive for perfection.
Comment #8
jenlamptonMarking this as "fixed" since the URL for the RSS icon can now be entered as any other service, as of the 1.4 release.
The Fix was included as part of #1953620: Overhaul the block/panels pane config form
Comment #9
tgeller CreditAttribution: tgeller commentedThanks! Sorry I didn't respond to your earlier comment -- I've been mostly out of commission.