This is a great module and I love the simplicity. I would love to be able to add an icon for an RSS feed that is not hosted on the Drupal site with this module.

Thank you,
Eric

CommentFileSizeAuthor
#4 rssfix-1432746-4.patch1.52 KBtgeller
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jenlampton’s picture

Hm. It would be possible to allow configuration of the RSS icon/link, I'll see about including this in the next version. Thanks for the suggestion :)

juliangb’s picture

Also keen on this feature - so that I can easily link to a RSS feed provided by views.

tgeller’s picture

I see this never made it in. Pretty please?

tgeller’s picture

Status: Active » Needs review
FileSize
1.52 KB

HOLY CRAP I FIXED IT. This is my first-ever real code contribution to contrib.

I left in comments, which could (and should) be removed. Jen?

jenlampton’s picture

Status: Needs review » Needs work

Thanks Tom!

It looks like this patch removes the intended (default) behavior that linked the RSS feed icon to the site's rss feed(s) and turns it into an "ordinary service". :)

Although that might work for your use case (and everyone else in this issue) most people using OTW and it's RSS icon would probably prefer not to have to enter in data Drupal already knows ("where is my RSS feed?"). I'd prefer if the option to define a feed were optional, so changing status to "needs work" so we don't loose existing functionality. (but for those who need it, please continue to use this patch!)

I'd like to do an overhaul of the settings form anyway, provide a checkbox for each available service, and use #states to show the URL fields only when the box is checked. Once that is done adding a second checkbox for "Use Drupal's internal RSS feed" that is checked by default for RSS should be a sinch.:)

Edit: see #1953620: Overhaul the block/panels pane config form

tgeller’s picture

Hi, Jen -- thanks for your fast response. At this point I'll have to leave the coding to someone else. I am bear of little brain.

Although I fully support the idea of making the RSS path field optional, I disagree somewhat that:

...data Drupal already knows ("where is my RSS feed?").

A site can have many RSS feeds, for blogs, product releases, news, etc.. Drupal can't know which is the important one to feature in a (persistent) block!

But again, I like the idea of making this a two-mode setting: 1) a checkbox for times where there's an obvious feed that Drupal can detect, and 2) a text field for other times.

jenlampton’s picture

There is rarely more than one RSS feed per page, so if the cache settings are DRUPAL_CACHE_PER_PAGE I think Drupal can continue to use it's magical drupal_get_feeds() function to link to the RSS feed icon to the feed on the current page.

I'm looking at this from the perspective of someone who wants to subscribe via RSS to "a site". They will almost always want the feed for the page they are on ("this blog" or "this product" or "this list of news articles", not some global site-wide feed) unless, of course, that particular page does not have a feed of it's own.

[ ] Provide a similar icon for RSS feed

and when that's checked, we show radios:

( ) use the RSS feed of the current page
( ) use the home page RSS feed
( ) specify RSS feed

when the fist option is checked (it will be checked by default)

When no RSS feed is present on the page
  ( ) use the home page RSS feed
  ( ) specify RSS feed
  ( ) do not display the RSS icon

Edit: The UI for this is getting rather complex (not to mention the code to drive it), and I'm now thinking that maybe letting people choose a single RSS feed for this block will be easier than my give-the-people-what-they-want approach, and this issue has been open for too long to strive for perfection.

jenlampton’s picture

Status: Needs work » Fixed

Marking this as "fixed" since the URL for the RSS icon can now be entered as any other service, as of the 1.4 release.
The Fix was included as part of #1953620: Overhaul the block/panels pane config form

tgeller’s picture

Thanks! Sorry I didn't respond to your earlier comment -- I've been mostly out of commission.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.