Validate regexs (to prevent Javascript / regex problem: invalid quantifier) [#1434104]

I'm having trouble with some invalid javascript, which is breaking collapsible fieldsets and other things. The firebug console gives:

invalid quantifier
extExclude = new RegExp(Drupal.settings.extlink.extExclude.replace(/\\/, '\\'))
extlink.js (line 33)

I suppose this may be due to an invalid regular expression (I can't remember if I entered any), but the problem is I cannot edit it (that fieldset is broken because of the problem).

I tried disabling and uninstalling extlink, but when I enable the module again afterwards the problem returns. Could an (invalid) regular expression remain in the database after uninstalling? Otherwise there may be an incompatibility with Domain Access (I'm using different domains).

Comment	File	Size	Author
#7	extlink-1434104-7.patch	1.22 KB	elachlan
#7
#5	extlink-rejexvalidate-1434104-5.patch	1.92 KB	katbailey
#5
#3	extlink-rejexvalidate-1434104-3.patch	1.7 KB	arvinsingla
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

quicksketch

he/him

CreditAttribution: quicksketch commented 9 February 2012 at 21:53

I suppose this may be due to an invalid regular expression (I can't remember if I entered any), but the problem is I cannot edit it (that fieldset is broken because of the problem).

Disable JavaScript in your browser and empty our your regular expressions while JS is turned off.

Comment #2

ar-jan CreditAttribution: ar-jan commented 10 February 2012 at 09:39

Status:

Active

» Fixed

Thanks, that worked. (Wondering: how come uninstalling and clearing cache didn't clear the regex?).

Comment #3

arvinsingla CreditAttribution: arvinsingla commented 15 February 2012 at 17:03

Status:

Fixed

» Needs review

File	Size
extlink-rejexvalidate-1434104-3.patch	1.7 KB

I'm re-opening this issue as It seems there are two issues this brings up with external links that need to be addressed. First is that the module does not remove it's variables on uninstall, the second is that the include/exclude form fields are not being validated for proper regex. This can lead to the aforementioned javascript issues which have adverse affects on sites. I've made a patch that I think addresses these issues but needs to be reviewed as I'm not sure if I'm going about the rejex testing in a proper way, but it seems to work for the tests I've thrown at it.

Comment #4

quicksketch

he/him

CreditAttribution: quicksketch commented 16 February 2012 at 02:06

Title:	Javascript / regex problem: invalid quantifier	» Remove variables on uninstall() and validate regexs (to prevent Javascript / regex problem: invalid quantifier)
Category:	support	» feature

Thanks, good suggestions. I'll review these next time I'm working on External Links.

Comment #5

katbailey CreditAttribution: katbailey commented 23 April 2012 at 22:11

File	Size
extlink-rejexvalidate-1434104-5.patch	1.92 KB

This reroll, actually by Andrew Yang not me, fixes comments and tidies things up generally...

Comment #6

ar-jan CreditAttribution: ar-jan commented 17 November 2012 at 17:52

Status:

Needs review

» Reviewed & tested by the community

The patch in #5 applies cleanly to 7.x-1.12 (don't have git installed, no -dev release?).
I don't know if there are coding issues, but I've tested it for preventing invalid regular expressions, that seems to work. Setting to reviewed & tested to bump this ;).

Comment #7

elachlan CreditAttribution: elachlan commented 15 July 2013 at 05:23

Title:	Remove variables on uninstall() and validate regexs (to prevent Javascript / regex problem: invalid quantifier)	» Validate regexs (to prevent Javascript / regex problem: invalid quantifier)
Status:	Reviewed & tested by the community	» Needs review