menu_tree_page_data - Custom Taxonomy menu - Menu Block

I have been working with the taxonomy menu with 'Custom Path' for menu path type. The requirement for this is to create a view with page display and path defined, in my case the view path is 'products' with taxonomy term as argument. No issues here.

I am using the Menu Block module to be able to show only the submenu items of the level 1 menu items. This works without any issue, for instance with the navigation menu. But the problem is that the custom taxonomy menu does not actually build the menu, therefore, in the menu_router table, there is only one router path defined as 'products/%' and this i beleive is generated by the view rather than the taxonomy menu.

So this is an issue when using the Menu Block module which calls the menu_tree_page_data function which then calls the menu_get_item(). Now in menu_get_items(), the function generates all the ancestors for the path but when it tries to find the route_path for each path in the ancestor array, in the menu_router table, of course it doesn't find but one which is 'products/%'. So when the item is return to the menu_tree_page_data, the $item['href'] will equal 'products' for any menu item that is generated by the Taxonomy menu of Custom Path type.

This makes it impossible for menu_tree_page_data to identify the parents of the menu item.

Menu Block cannot therefore generate a menu tree for second level menu items.

So I was troubleshooting and found where the problem lies and this is in the menu.inc for the menu_tree_page_data function, and making the modification as below fixed the problem:

(THIS WAS JUST FOR TESTING PURPOSES AND I DIDN'T KEEP THE CHANGES MADE TO CORE)

my modification is where there is lots of space between lines, in two places

function menu_tree_page_data($menu_name = 'navigation') {
  static $tree = array();

  // Load the menu item corresponding to the current page.
  if ($item = menu_get_item()) {
    // Generate a cache ID (cid) specific for this page.


/***********CHANGE HERE*************************/
  $path = $_GET['q']; //added
    //$cid = 'links:'. $menu_name .':page-cid:'. $item['href'] .':'. (int)$item['access'];
    $cid = 'links:'. $menu_name .':page-cid:'. $path .':'. (int)$item['access']; //added



    if (!isset($tree[$cid])) {
      // If the static variable doesn't have the data, check {cache_menu}.
      $cache = cache_get($cid, 'cache_menu');
      if ($cache && isset($cache->data)) {
        // If the cache entry exists, it will just be the cid for the actual data.
        // This avoids duplication of large amounts of data.
        $cache = cache_get($cache->data, 'cache_menu');
        if ($cache && isset($cache->data)) {
          $data = $cache->data;
        }
      }
      // If the tree data was not in the cache, $data will be NULL.
      if (!isset($data)) {
        // Build and run the query, and build the tree.
        if ($item['access']) {
          // Check whether a menu link exists that corresponds to the current path.

/***********CHANGE HERE*************************/
         //$args = array($menu_name, $item['href']);
         $args = array($menu_name, $path);//added

Since menu_get_item() never gets passed the optional 'path' argument and ends up using the default value of $_GET['q'], is it ok to make this modification in the menu_tree_page_data function? If not, has anyone had this problem and is there a better solution?

Any help is greatly appreciated and I hope that I have described the issue as clearly as possible.