From what I can tell, the only reason the expire dependency exists is for the expire_print_r() function.

Attached patch copies this function locally and removes the dependency.

CommentFileSizeAuthor
#7 remove_expire_dependency-1442996-7.patch2.61 KBwwhurley
#5 remove_expire_dependency-1442996-5.patch2.81 KBwwhurley
remove_expire_dependency.patch2.47 KBmsonnabaum
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
CreditAttribution: anavarre commented

I've tested this patch and can confirm this removes the dependency.

SqyD’s picture

SqyD CreditAttribution: SqyD commented
Version: 7.x-1.x-dev » 7.x-2.x-dev

I'll address this in the 2.x branch. Should also take #1474876: Error Messages "Notice: Undefined index: host in purge_urls() (line 27 of [...]modules/purge/purge.inc)" being displayed into account.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
CreditAttribution: kscheirer commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Category: feature » task
Status: Needs review » Reviewed & tested by the community

This is still a problem, and purge 2.x looks far away, can this get into the next release?

SqyD’s picture

SqyD CreditAttribution: SqyD commented

Okay, okay, okay... You've convinced me... Will do this... sigh. :-)
Planning for a 1.7 release that will drop the dependency on expire, have functionality to add domains (thus also work when the module calling the expire hook doesn't supply a domain in the url)... should be out in a few weeks. I would appreciate a backport to 6.x since I strive to keep D6 and D7 versions in sync.

BTW: purge 2.x is surprisingly function, just not done yet.

wwhurley’s picture

wwhurley CreditAttribution: wwhurley commented
Issue summary: View changes
FileSize
remove_expire_dependency-1442996-5.patch2.81 KB

Attached is a re-roll of the patch to work with the latest 7.x-1.x branch.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
CreditAttribution: kscheirer commented

This chunk of the patch should be removed. Leaving the issue as RTBC though, it's a trivial fix.

+
+; Information added by drupal.org packaging script on 2013-10-01
+version = "7.x-1.6+2-dev"
+core = "7.x"
+project = "purge"
+datestamp = "1380624347"
+
wwhurley’s picture

wwhurley CreditAttribution: wwhurley commented
FileSize
remove_expire_dependency-1442996-7.patch2.61 KB

Re-rolled to remove packaging script information.

SqyD’s picture

SqyD CreditAttribution: SqyD commented
Status: Reviewed & tested by the community » Fixed

Patch committed to 7.x-1.x branch. Thanks!

  • SqyD committed ba7847f on 7.x-1.x authored by scor 
    Issue #1442996 by msonnabaum, wwhurley: Remove dependency on Expire.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.