HTML5 wrapper wanted

Pushed to git. Thx for the patch, the second that is ;)

Marking major as 7.x-1.2 really can't be released without this one.

I suggest we create one very dynamic html5 wrapper. Choose html tag and classes.

Is #2 applied to latest 1.x dev - I do not see any of html5 tags in any option.
Need any testing help?

I do not see anything funny - except I do not read all the module description (because some of them are not updated as the development progresses).
My tas is simple, to get artice-header-footer and other html5 goodies

I cannot apply the patch (on Windows)

missing header for unified diff at line 5 of patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/field_group.module b/field_group.module
|index ab1ff26..8d813b6 100644
|--- a/field_group.module
|+++ b/field_group.module
--------------------------
File to patch: field_group.module
patching file field_group.module
missing header for unified diff at line 38 of patch
can't find file to patch at input line 38
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|@@ function field_group_field_group_formatter_info() {
|         'instance_settings' => array('description' => '', 'show_label' => 1, '
label_element' => 'h3', 'effect' => 'none', 'speed' => 'fast', 'classes' => '',
'required_fields' => 1),
|         'default_formatter' => 'open',
|       ),
|+      'html5' => array(
|+        'label' => t('HTML5'),
|+        'description' => t('This fieldgroup renders the inner content in a sem
antic HTML5 wrapper'),
|+        'instance_settings' => array('wrapper' => '', 'classes' => ''),
|+      ),
|       'fieldset' => array(
|         'label' => t('Fieldset'),
|         'description' => t('This fieldgroup renders the inner content in a fie
ldset with the title as legend.'),
--------------------------
File to patch:
Skip this patch? [y] y
Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 51 of patch
can't find file to patch at input line 51
Perhaps you used the wrong -p or --strip option?
File to patch: EOF
Skip this patch? [y]
t:\static\platforms\d717\sites\all\modules\field_group>patch -p1 < field_group_v
1_html5.patch
patching file field_group.module
Assertion failed: hunk, file ../patch-2.5.9-src/patch.c, line 354

I can confirm the patch in #10 works for me, thx.

Two things that come to mind:

• small typo: Footer in the dropdown isn't titlecase ('footer' rather than 'Footer')
• Maybe the label is obsolete for HTML as it's not actually doing anything at the moment (as far as I can tell).

Should the DIV and HTML5 wrappers be combined into a general wrapper field group type?

duplicate

duplicate

Closed this issue because of #1926938: Simple html wrapper.