Let's make the field-collection interface properly translatable via i18n. Attached patch already cares about page titles when adding/editing/deleting field-collections via the formatter-links.

todo: Make edit/delete/add links translatable.

Files: 
CommentFileSizeAuthor
#4 field_collection_i18n.patch7.53 KBfago
PASSED: [[SimpleTest]]: [MySQL] 77 pass(es).
[ View ]
#3 field_collection_i18n.patch7.43 KBfago
PASSED: [[SimpleTest]]: [MySQL] 77 pass(es).
[ View ]
field_collection_i18n.patch2.94 KBfago
PASSED: [[SimpleTest]]: [MySQL] 78 pass(es).
[ View ]

Comments

I cannot give this a proper review, only test it.

a few other todos(?):

- "Manage fields" and "Manage display" tabs titles don't return the collection's proper label. They have its machine name instead.

- The configuration page lists field collections by their machine name too. "Field name" column should perhaps be "Collection field" and display the proper label instead.

- The title of the "Translate Field instance" tab should also perhaps be "Translate [proper_label] collection field instance".

- "Manage fields" and "Manage display" tabs titles don't return the collection's proper label. They have its machine name instead.

Agreed, that's not really related to translation though. Let's deal with it separately.

- The configuration page lists field collections by their machine name too. "Field name" column should perhaps be "Collection field" and display the proper label instead.

Which configuration page are you talking of?

- The title of the "Translate Field instance" tab should also perhaps be "Translate [proper_label] collection field instance".

Again, which tab do you mean? The "translate" tab? That one is generated by i18n_field.

StatusFileSize
new7.43 KB
PASSED: [[SimpleTest]]: [MySQL] 77 pass(es).
[ View ]

Attached is a completed patch which adds translation support for edit/delete/add links. It's odd that one have to translate them separately, but that's how i18n deals with it. I don't think we can do anything about it.

StatusFileSize
new7.53 KB
PASSED: [[SimpleTest]]: [MySQL] 77 pass(es).
[ View ]

missing check for existing defaults

Status:Needs review» Fixed

and committed.

Note, that this depends on a recent entity api dev verision. I'll roll a new release asap though, so ideally the next field collection release could add a versioned dependency.

Status:Fixed» Needs review

Tested #4 again and it does what it advertises.

Which configuration page are you talking of?

Structure -> Field collections (/admin/structure/field-collections)

Again, which tab do you mean? The "translate" tab? That one is generated by i18n_field.

Yep, that'd be the one. You're right, sorry.

Status:Needs review» Fixed

...sorry, x-post.

Note, that this depends on a recent entity api dev verision.

I always use latest devs where available ;)

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.