Add event handlers

My javascript isn't any good so I'll trust your judgment on this one. I did test to confirm that that player is loading and working fine after the patch is applied. Committed, thanks!

Hi Andy,

Would you mind to post the module code function , I'm not sure how to send the variables to the Drupal behaviour.

Thank you

Julian

Nevermind this is the preprocess function you should use for sending the events

function [your_module_name]_preprocess_jw_player(&$variables) {
	$variables['config']['events'] = array(
			'onComplete' => 'function() { alert("onComplete")}',
	);
}

Julian Mancera

function [your_module_name]_preprocess_jw_player(&$variables) {
	$variables['config']['events'] = array(
			'onComplete' => 'function() { alert("onComplete")}',
	);
}

I try to use this function but i am getting an error, because events are passed as strings.
How can i do that? I already use the patch for jw_player.js...

When I use the following:

function [your_module_name]_preprocess_jw_player(&$variables) {
$variables['config']['events'] = array(
'onComplete' => 'function() { alert("onComplete")}',
);
}

I get the following outputted. And it causes an error:

SyntaxError: missing } after property list

       jwplayer('jwplayer1commercial').setup({
              "file":"Know.mp4",
              "width":"720",
              "height":"480",
              "stretching":"uniform",
              "autostart":"true",
              "events":{
                 "onComplete":"function() { alert("onComplete")}",
              }
       });

What am I doing wrong?

Thanks

IMHO, there is no changes needed in the JW Player module. The patch in #1 uses JavaScript eval() of inline code in order to allow JavaScript callbacks to be written in PHP strings. Writing inline JavaScript in PHP string is ugly and error prone, it should be avoided. But the proposed patch actually encourage it. eval() is also incompatible with strict and secure JavaScript, as enforceable using the Content Security Policy HTTP header.

The proper solution would be to include an additional JavaScript file that uses the JW Player JavaScript API on the page containing the view. If the file is added by a theme, it will be included after the jwplayer.js and jw_player.js files. If the file is included by a module, a weight should be set in order to ensure proper ordering of the .js files.

Something like this should do for the additional JavaScript files.

(function($) {
  Drupal.behaviors.nameOfTheCustonModuleOrTheme = {
    attach: function(context, settings) {
      $('#views_slideshow_cycle_main_front_slideshow-default').once('name-of-the-custom-module-or-theme', function() {
        var $this = $(this);
        jwplayer().onPlay(jQuery.proxy($this.cycle, $this, 'pause'));
        jwplayer().onPause(jQuery.proxy($this.cycle, $this, 'resume'));
        jwplayer().onComplete(jQuery.proxy($this.cycle, $this, 'resume'));
      }
    }
  }
})(jQuery);

I'm closing this a 'work as designed' for the reasons explained in #8 (ie. JavaScript code belongs in .js file, not in PHP).