When I install the Mongodb block module, after I have had block module deactivated, I get the error message Constant BLOCK_REGION_NONE already defined in require_once().

This was also reported here by @langworthy: http://drupal.org/node/1163584#comment-5496150.

We could have different approaches to this, here are three

  1. Delete the constant defined by block module and define it again in the Mongodb block module
  2. Delete the constant defined by block module and define our own
  3. Keep the block module constant and define our own.

I do not like to keep things in the configuration that I do not use, and there could also be other modules that depends on checking BLOCK_REGION_NONE (I do not know if there are any, but anyhow, you could) so my personal vote goes to number one.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MiSc’s picture

Patch for the above number 1.

MiSc’s picture

Status: Active » Needs review
MiSc’s picture

Any opinions on this?

fgm’s picture

Solution 3 seems the most consistent with Drupal practice in general.

MiSc’s picture

Ok, patch for solution #3.

Status: Needs review » Needs work

The last submitted patch, BLOCK_REGION_NONE_defined-1447806-5.patch, failed testing.

MiSc’s picture

Status: Needs work » Needs review

Could someone do a review on this? Should be nice to have, so we could get rid of the error message.

MiSc’s picture

Status: Needs review » Fixed

Committed to latest dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.