Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Suggestion for bug fix
When getting cached messages, in multisites, if 2 chats have the same ids, the messages appear in both sites.
Code shows in chatroom.cache.apc.inc:
$cache_id = variable_get('chatroom_cache_prefix', 'chatroom_cache_prefix') . '_' . $chat_id;
You should include a salt or some kind of site specific id in the APC var name to be sure it doesn't fetch the wrong drupal site in multisite config.
The 'chatroom_cache_prefix' shall manage this I imagine, but it never gets set. At least set the default value to the global $cookie_domain of the site, this might help.
Regards
Sebastien
Comment | File | Size | Author |
---|---|---|---|
#2 | chatroom-multisite-bug-1450646-2.patch | 8.27 KB | emmene-moi |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedyes, this is a good idea. patches welcome.
Comment #2
emmene-moi CreditAttribution: emmene-moi commentedPatch works on my multisite install with APC.
Submitted patch solves issue with or without apc or memcache.
Added settings to modify the default prefix (not mandatory to be included to the prod version).
Regards
Seb
Comment #3
emmene-moi CreditAttribution: emmene-moi commentedMarked #716194: Not work in multisite installation as duplicate of this issue
Comment #3.0
emmene-moi CreditAttribution: emmene-moi commenteddetails code location