I have been poking around at wysiwyg-media.js in an attempt to get inline audio embeds working.
It seems inline media is broken for all media types except for images. This has been documented/discussed in a couple of places already (http://drupal.org/sandbox/dman/1075470.and ). There also appears to have been a few proposals to overhaul the inline media approach and
I think the above proposals are definitely worth discussing further however, in the meantime it would great if this would "just work".
The breakage appears to be caused in a couple of places where things are very image-specific, particularly insertMediaFile() and createTag(). It doesn't look like it'll be much work to clean these up. In the interest of not breaking stuff that currently works, I am wondering if anyone who is familiar with the history of these methods could weigh in on why they do some of the things they do.
- stripDivs(): Seems like this exists to work around some wysiwyg eccentricities, though has been written to be specific to images. Should this apply to other elements?
- createTag(): provides special handling for IE and token replacements for positioning inline images and setting width/height attributes - maybe this can be moved into a image handler?
- attach() and addImageAttributes(): It looks like all of the inline macro code has been written with only images in mind, the macro format should probably be generalized a little bit.
I have made a start on this, will post patches tomorrow.
|FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1451316-44-media-wysiwyg_integration_cleanup.patch. Unable to apply patch. See the log in the details link for more information. |
[ View ]
|FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1451316-43-media-wysiwyg_integration_cleanup.patch. Unable to apply patch. See the log in the details link for more information. |
[ View ]
|#38||Screen Shot 2012-08-07 at 15.04.00.png||32.85 KB||mrfelton|