After clicking on the link in the confirmation mail I get an "Access denied"
The subscriber doesn´t get confirmed.

Comments

ParisLiakos’s picture

Do anonymous users have subscribe newsletters permission?

anni’s picture

Yes.

ParisLiakos’s picture

whats the URL like?

anni’s picture

Hi,

it´s "...newsletter/confirm?hash=k60TQyNwstUXYtSCn84QjbGlN670GrQMTd6efSZMOzU".

ParisLiakos’s picture

hmm i have no clue as to what could cause this behavior:/
any entries in reports recent logs (dblog) ?

anni’s picture

Yes.

Type: access denied
Date: Thursday, February 23, 2012 - 12:51pm
User: Anonymous (not verified)
Location: .../newsletter/confirm?hash=k60TQyNwstUXYtSCn84QjbGlN670GrQMTd6efSZMOzU
Referrer:
Message: newsletter/confirm
Severity: warning
Hostname: ...
Operations:

ParisLiakos’s picture

Status: Active » Closed (cannot reproduce)

sorry,no idea whats causing this.maybe another module you are using?

anni’s picture

Maybe simplenews?
I´ll try a clean installation and will report back.

ParisLiakos’s picture

Title: Clicking on confirmation link in mail shows "Access denied" » Change newsletter/* menu paths to simplenews/*
Project: Newsletter » Simplenews
Version: 7.x-1.0-beta6 » 7.x-1.x-dev
Status: Closed (cannot reproduce) » Active

Yes simplenews could be the cause, since it has a menu entry newsletter/confirm just like newsletter module does.
Simplenews should use simplenews/confirm instead.
Thus i am sending this to simplenews issue queue

miro_dietiker’s picture

Status: Active » Closed (won't fix)

We prefer to state "Simplenews conflicts Newsletter module".
First simplenews was first to "allocate" the /newsletter/ module namespace.

Then, simplenews provides concepts like "Newsletter" and not a "Simplenews". We decided during name cleanups to confirm this previous name also.
Also if we once will implement an entity for the Newsletter, the entity will have a name like "Newsletter" and not "Simplenews"...

Even if you think this might be wrong and a namespace in the URL should be prefixed with the module name, we won't be able to do that. Beta level guarantees API stability and the callback URL is an API relevant thing. We won't break millions of already sent links.

I still vote for a merge of those modules and i also don't see a reason to use both at the same time.

ParisLiakos’s picture

Agreed on most points but

Also if we once will implement an entity for the Newsletter, the entity will have a name like "Newsletter" and not "Simplenews"

Module's name and URL here in d.o was and is the namespace.It is the best practice to use your module's namespace to avoid incompatibilities like these.

First simplenews was first to "allocate" the /newsletter/ module namespace.

It was the wrong thing to do and still is.Just because it happened doesnt make it right:)

That said, i agree, no point to break existing links and API (especially when its highly unlikely for one to use these 2 modules together), but it should be noted as a thing to fix in the future.I would say "postponed" is the right status here

Berdir’s picture

Status: Closed (won't fix) » Postponed

Agreed with postponed, we might look into this later. I am not sure if the namespacing rules apply to menu paths like they do to function names but I also agree that newsletter doesn't belong to us just because we were here first.

And yes, would be wrong to change it now and break all existing links and integrations.

I will add a point to the known problems section.

anni’s picture

@rootatwc

So, at the time there is no chance to get a working confirm link (in newsletter module) if newsletter and simplenews is installed both?

Berdir’s picture

No, there isn't.

Why would you want to use both modules at the same time anyway, that makes no sense?

anni’s picture

Because I need functions from newsletter module (include Views, send newsletters after x days, etc.), but encountered bugs.
So I had to find a solution for standard newsletters and thats the good old simplenews.

Berdir’s picture

See http://drupal.org/project/simplenews_scheduler for recurring newsletters and inserting views can for example be done in the templates.

anni’s picture

Hmmmmm, why not. I´ll give it a try.
Thank you!

ParisLiakos’s picture

great, we can come back to this and fix it once the 2.x-dev branch opens:)

Abelito’s picture

Im not sure how different the module is for Drupal 6, but I submitted a patch for the D6 version here: http://drupal.org/node/1801300
- I have tested it, and it seems to be working just fine.

miro_dietiker’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Postponed » Active

Reopening in 7.x-2.x.
We can discuss now about a new naming scheme.

j.johnson.bbt’s picture

Suppose someone installed both Simplenews and Newsletter and then they uninstall both.

How do they go about deleting this menu entry "newsletter/confirm" so they can start over with a fresh install? Thanks.

AdamPS’s picture

Version: 7.x-2.x-dev » 4.x-dev
Issue summary: View changes
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.