Hey there,

Thanks for the very useful module. I was just wondering though why did you guys chose to use Htmlmail in v2 rather than Mime mail module ?

Thanks

CommentFileSizeAuthor
#4 commerce_email-mimemail-1454548.patch932 bytesreswild
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kruser’s picture

I was hoping you could remove the dependency on htmlmail so we could use mimemail as a alternative. I'm currently using mimemail with commerce email and I'd like to turn off htmlmail but cant because it's required.

pixelsweatshop’s picture

Title: HtmlMail vs Mime Mail » Remove HtmlMail as a dependency

Although the OP was asking about the choice that was made, I think this is a larger issue about forcing a dependency on one module, when there are many others for handling html emails.

We are using neither HTMLmail nor mimemail (using Mandrill). Having HTML mail as a dependency is unnecessary for us as well. What about removing this dependency and recommending to users to choose their preferred method for sending html emails?

IckZ’s picture

Issue summary: View changes

any updates? I would also like to use mimemail instead of htmlmail :)

reswild’s picture

Status: Active » Needs review
FileSize
932 bytes

Just comment out the HtmlMail dependency in the .info file, and you are good to go.

Here is a patch that also checks if you are using HtmlMail or MimeMail when installing.

IckZ’s picture

reswild++

thanks for the patch - hopefully it will be commited to dev.

pixelsweatshop’s picture

Status: Needs review » Needs work

Here is a patch that also checks if you are using HtmlMail or MimeMail when installing.

This is great but what about other mail services. We are currently using mandrill and not html mail/mime mail. I think the dependency needs to be removed all together and let's just document that you need something for html mails.

reswild’s picture

The patch does remove the dependancy altogether. It adds a configuration for either HtmlMail or MimeMail on install if one of these modules are active, but there is nothing stopping you from using a different mail system if you prefer that.

pixelsweatshop’s picture

Sorry i should have looked at the patch before posting, Based on your comment it seemed it only required one or the other.

pixelsweatshop’s picture

Status: Needs work » Needs review
joelpittet’s picture

Category: Support request » Feature request
Status: Needs review » Reviewed & tested by the community
Spleshka’s picture

Run into the same issue, confirm that patch solves the issue.

rszrama’s picture

Reviewing...

rszrama’s picture

Status: Reviewed & tested by the community » Fixed

Not a very generic solution, but at least it's not a regression. Committing with a whitespace fix.

  • rszrama committed 7f12550 on 7.x-2.x authored by reswild
    Issue #1454548 by reswild, rszrama: Remove HtmlMail as a dependency
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.