Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hey there,
Thanks for the very useful module. I was just wondering though why did you guys chose to use Htmlmail in v2 rather than Mime mail module ?
Thanks
Comment | File | Size | Author |
---|---|---|---|
#4 | commerce_email-mimemail-1454548.patch | 932 bytes | reswild |
Comments
Comment #1
kruser CreditAttribution: kruser commentedI was hoping you could remove the dependency on htmlmail so we could use mimemail as a alternative. I'm currently using mimemail with commerce email and I'd like to turn off htmlmail but cant because it's required.
Comment #2
pixelsweatshop CreditAttribution: pixelsweatshop commentedAlthough the OP was asking about the choice that was made, I think this is a larger issue about forcing a dependency on one module, when there are many others for handling html emails.
We are using neither HTMLmail nor mimemail (using Mandrill). Having HTML mail as a dependency is unnecessary for us as well. What about removing this dependency and recommending to users to choose their preferred method for sending html emails?
Comment #3
IckZ CreditAttribution: IckZ commentedany updates? I would also like to use mimemail instead of htmlmail :)
Comment #4
reswild CreditAttribution: reswild commentedJust comment out the HtmlMail dependency in the .info file, and you are good to go.
Here is a patch that also checks if you are using HtmlMail or MimeMail when installing.
Comment #5
IckZ CreditAttribution: IckZ commentedreswild++
thanks for the patch - hopefully it will be commited to dev.
Comment #6
pixelsweatshop CreditAttribution: pixelsweatshop commentedThis is great but what about other mail services. We are currently using mandrill and not html mail/mime mail. I think the dependency needs to be removed all together and let's just document that you need something for html mails.
Comment #7
reswild CreditAttribution: reswild commentedThe patch does remove the dependancy altogether. It adds a configuration for either HtmlMail or MimeMail on install if one of these modules are active, but there is nothing stopping you from using a different mail system if you prefer that.
Comment #8
pixelsweatshop CreditAttribution: pixelsweatshop commentedSorry i should have looked at the patch before posting, Based on your comment it seemed it only required one or the other.
Comment #9
pixelsweatshop CreditAttribution: pixelsweatshop commentedComment #10
joelpittetComment #11
SpleshkaRun into the same issue, confirm that patch solves the issue.
Comment #12
rszrama CreditAttribution: rszrama at Centarro commentedReviewing...
Comment #13
rszrama CreditAttribution: rszrama at Centarro commentedNot a very generic solution, but at least it's not a regression. Committing with a whitespace fix.