Add continent field widget

Nice. I like. This is a huge UI improvement in a 250 element select list. :)

A few things:

1) Make sure that you use t() on all strings.

+ '#title' => 'Select a country',
+ '#title' => t('Select a country'),

2) I do not think that the #description is needed on the iso2 sub-element and just "Country" rather than "Select a country". On a multi-value field, both become very repetitive.

3) A bit of internal structure could be done to help themers to condense this. Maybe a wrapper DIV with a clearfix class. That should be enough to easily float the sub-widgets inline if someone so desires.

If you are really keen, a custom theme callback could be warranted. Looking at the results, I want to move the Continent and Country labels into #descriptions rather than #titles, but this is my preferred style for multi-component fields, others dislike this.

4) The array_intersect_key logic should be moved into the widget form logic, otherwise there is the danger of interfering with other fields (ie: updating the drupal_static() result).

Un-related: This will expose the following "@todo I18n for user defined overrides." for continents. This is a separate issue though. @webflo any thoughts on this?

The patch didn't apply, so I'll try again tomorrow. I need to run through single / multiple entities and also the default value form field (post setting the widget).

BTW, I did mean wrapping both the continent and iso2 elements within the same DIV. I can not remember if you can just append to the base $element or not. Maybe:

    // Support floating inner floating elements.
    $element += array(
      '#prefix' => '',
      '#suffix' => '',
    );
    $element['#prefix'] .= '<div class="clearfix countries-continent-wrapper">';
    $element['#suffix'] = '</div>' . $element['#suffix'];
    // @todo I18n for user defined overrides. <<Removed a dr from here. This can be dropped as the todo is already flagging this elsewhere :)

I found issues with the instance default value form. This gets regenerated a couple of times per submission, so the unique ID never seemed to match the settings. It works once, then fails. I think that it is fairly safe to create our own via the parameters passed in.

I've added a number of other slight modifications.

Another minor restructure.

You can not assume that the field form is in this structure (ie: because of Profile2 and Field Collections);

Does this seem cleaner? (untested)

$parents = array_slice($form_state['triggering_element']['#array_parents'], 0, -1);
$parents[] = 'iso2';
return drupal_array_get_nested_value($form, $parents);

I think that the "breaking the visible condition" was me overlooking the role of the JQuery selector. Reverting the empty value from NULL to 'none' should fix this.

ie:

      '#empty_option' => t('-- None selected --'),
-      '#empty_value' => NULL,
+      '#empty_value' => 'none',

Starting to focus on the minor details, reselecting '-- None --' does not reset the visibility of the country select loaded by Ajax. Any ideas?

But it is probably ready to go without the worrying too much about "reselecting '-- None --' does not reset the visibility". As per #7 with #empty_value bug that I introduced fixed. I'll re-roll in about 4 to 5 hours.

Hi there,

I am evaluating the possibility to use your continent widget, and it kind of conflict with the CAPTCHA module.

I added a country field on the user profile (core profile), with the continent widget. I am using the captcha module to prevent bots from registering on my site, and the captcha module come with some kind of protection against session reuse. When trying to register a new user on my site with the continent widget, after selecting the continent, and before selecting the country itself, the captcha module display an alert: "CAPTCHA session reuse attack detected".

I don't know whether all ajax requests on the user registration form would generate such error message.

Cheers,

Sylvain

ps: using dev version with the continent patch of the country module, and the latest stable version of catcha.

Yes, it is an issue with the CAPTCHA module itself, see #918856: CAPTCHA Session Reuse message on webforms .

Committed. Great work.

Some things that I found and fixed in testing.

1) Unsetting the iso2 element in _ajax_countries_continent_widget_callback() blocked all AJAX other submissions by the element. This is probably a bug in core, but I worked around by adding a hidden div wrapper. I updated the countries element to optionally hide if there are 0 options or 1 option of type #empty_value.

2) I got a PDO exception when saving a country value of type 'none'. I changed this to just ''. The JScript tests the continent filter value for the show / hide toggle.

You can see the diff here: http://drupalcode.org/project/countries.git/commitdiff/77dfd39?hp=f3f1f8...

My pleasure, it is a very useful addition to the module :)

this patch is causing a break. is this just on my machine? any idea what could be causing the issue.

patching file countries.fields.inc
Hunk #1 succeeded at 268 (offset 13 lines).
Hunk #2 succeeded at 366 (offset 90 lines).

$ drush status
Drush command terminated abnormally due to an unrecoverable error.   [error]
Error: Cannot redeclare countries_field_widget_info() (previously
declared in
/applications/mamp/htdocs/location/sites/all/modules/countries/countries.fields.inc:263)
in
/applications/mamp/htdocs/location/sites/all/modules/countries/countries.fields.inc,
line 281

@pcambra

An issue was reported with this in #1620276: Widget "countries by continent" issues due to AJAX #limit_validation_errors and nested forms (Field Collections, Profile2), I'd love a second pair of eyes on the patch before committing this.

It is in relation to the widget simply breaking when used in Profile2 profiles. I managed to replicate this using Field Collections, and once replicated, easily fixed the error on my installation.

Hi, Thanks for this awesome piece of work.

Any hints on using it in FAPI style created form ?

Clear resolution message

13: 1459850-countries-add_continent_widget-13.patch queued for re-testing.

@vipul.jadvani
This is already in the dev version if not the latest tagged release ;)