The module's name is "Entity Views Attachment", but when you go to add the display item to a view nowhere do you see "Entity Views Attachment" or even "Entity attachment", you just see "Attachment" and "Entity content". As a beginner to the module this is definitely confusing and it would help if "Entity content" was named "Entity attachment" to at least draw some connection to the module name.

Files: 
CommentFileSizeAuthor
#2 eva-n1461518.patch1.69 KBDamienMcKenna

Comments

Category:feature» bug

Changing this to a bug report.

Status:Active» Needs review
StatusFileSize
new1.69 KB

Here's a patch that makes the change I recommended in the issue description above.

This has been a bit of a back-and-forth debate internally, because technically it's adding a view to the content area of an existing entity. I'm willing to commit it, but I wish I could put up a poll or something... Hrm.

When I first read this issue summary, I though ....yeah you're right. With all the different modules that add displays to Views, I too was initially confused about the Entity Content display. And, quite honestly, it took me a while to figure out which module established the display. Nevertheless, the internal debate describe in #3 seems very valid.

Would 'EntityContent Attach' or 'Entity Content -EVA' or 'EVA Atttachment' be too long for a Views display name?

@rwilson0429: I don't see any point in having the word "Attachment" repeated, i.e. "EVA Attachment" is redundant.

The reason I didn't include the word "content" in the name in the patch is that it's too vague - what exactly is a "content area" of an entity? Is the field settings the "content area"? Is the display settings the "content area"?

Another option could be "Entity display attachment", but again I feel that might confuse matters as it adds another word to the title that is not present in the module name. If the module was named "Views Entity Display Attachment", e.g. views_eda, then I could see naming the display option "Entity display attachment", but right now it's just called "Entity Views Attachment".

Is the dead horse flogged enough? =)

I think using "Entity Attachment" could be confusing when comparing to the "Attachment" display.

Views Attach, in D6, was using "Node content", so I suppose "Entity Content" is the logical adaptation, and should not confuse people who comes from D6.

I'm in favor of keeping things as they are, as I managed to have it working this way ;-)

Title:Rename "Entity content" display "Entity attachment"Rename "Entity content" text in UI

I managed to have it working this way

Indeed, but current terminology is confusing every time, over and over, again and again, ... ;-)

We wouldn't have this discussion if the module's name was 'Views Entity Attachment'. You'd use 'Entity attachment' everywhere, but ware are stuck with the abbreviation. (Is a module rename a possiblilty?)

Below I have quoted all texts in the 'life cycle' of this module.
A users start with 'Eva', and end up with 'Entity content'. That confusing. Changing it to 'Entity Attachment' is no remedy IMO. So IMO we need to keep 'Eva' everywhere.

In the end, Eva does the same as View reference:
- It adds/attaches a Views display to the content of an entity.
- You create a new field for an entity.

I would propose:
- Remove the word content altogether, and start using field.
- Start using: 'Eva Entity Field' or 'Eva - Entity field'
- As an alternative: 'Eva - Entity Attachment' . (As opposed to the standard 'Views Attachment', which attaches to a view, not an entity.)
- The use of 'Eva' might be redundant, but is makes the DX/UX consistent throughout the life cycle.
- As an (irrealistic) alternative: rename the module to 'Views entity attachment'

Cheers.

As promised, a list of appearances of the discussed term:
1. Project page / Readme file:
"Eva" is short for "Entity Views Attachment;"
"it provides a Views display plugin that allows the output of a View to be attached to the content of any Drupal entity. The body of a node or comment, the profile of a user account, or the listing page for a Taxonomy term are all examples of entity content.
The placement of the view in the entity's content can be reordered view will appear on the "Field Display" administration page for that entity, like other fields added using the Field UI module."

2. Modules page:
Eva - Provides a Views display type that can be attached to entities.

3. Add new Views display:
Add / Entity content (vs. Add / Attachment from Views module)

4. View an Eva display:
"ENTITY CONTENT SETTINGS"

Status:Needs review» Active

I agree. Content means nodes as far as I'm concerned...so 'Entity Content' isn't a good name for the view display. How about just 'EVA Field' ?

Status:Active» Fixed

The change to 'EVA Field' is in the latest dev release. New release coming soon. Please test the dev release to spot any bugs.

That'll do, thanks mkadin :)

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.