Hi I followed #1334942: Drupal 7 OpenChurch Port for your port to 7. I love using makefiles. I especially want to be able to use your makefile so I can keep it up to date or add my own modules. I typical use a makefile that specifies a tag. like this.
includes[] = http://github.com/xforty/xforty-drupal/raw/7.x/xforty-com.make
projects[xforty][type] = profile
projects[xforty][download][type] = git
projects[xforty][download][url] = git://github.com/xforty/xforty-drupal.git
projects[xforty][download][tag] = {TAG}
Which isn't to dissimilar from what you have. I look at your tag.
http://drupalcode.org/project/openchurch.git/commit/8d2f47c0e38aac611591...
It seems older than your current receive. What is your tagging strategy? Or how quickly do you intent to respond to security fixes with bundling your zip file.
Comments
Comment #1
pearcec CreditAttribution: pearcec commentedI also wanted to point out the fact you don't pin version in your makefile. So if someone goes to build it they are getting different versions that might be incompatible with the features you supply. Have you given thought to pinning the versions? If you don't you get results like below as well. Here is a good example of a pinned base makefile
This is the makefile I used to try and build it.
Comment #2
drupalninja99 CreditAttribution: drupalninja99 commentedYa right now for convenience I build downloads from HEAD and then I will test snapshots from time to time and tag them as stable on the download page:
http://openchurchsite.com/openchurch-download
Ideally I would like to move towards adding the make file directly to the d.o. project page, I just need to confirm that I can add my 3rd party libraries there. For sometime the inability to add 3rd party libraries has made distro maintainers host them on their own site.
Comment #3
drupalninja99 CreditAttribution: drupalninja99 commentedGoing to close for now but this is on my radar.
Comment #4
pearcec CreditAttribution: pearcec commentedI found a really descent way to keep up to date with your zip file, and include my own modules. I don't know if we can add this to some documentation. But I thought I would at least get it into a support request for others. This only works for Drupal 7. All the modules, themes, and libraries included with this distribution are located under
profiles/openchurch
. It is possible to add module to sites/all and have it override the defaults inprofiles/openchurch
. If a security update comes out or you want to include your own modules you can create the following make file.You can leave off the subdir if you want. It will simply go into the modules directory. It is convention to use contrib for drupal contributed modules and custom for your own.
Hope this helps someone.
Comment #5
drupalninja99 CreditAttribution: drupalninja99 commentedYa I figured that adding modules to sites/all did override the platform. Most of my audience is not using make files though.
Good news on the version front is that it looks like the superfish js library is getting whitelisted now which is the last library I need whitelisted to try out a full make file. Once I can bring the packaging back to d.o. I think things will be a lot smoother bc I will have specific versions all catalogued and available for download. It will help the issue queue as people will be able to select specific versions.
Comment #6
drupalninja99 CreditAttribution: drupalninja99 commentedOK good news, the make file is finally cleaned up with pinned versions and whitelisted libraries so now you can download openchurch direct from the project page.