Right now, you get a 404, this seems to be confusing for some users.

Something like "Nothing needs to be confirmed. Maybe the confirmation link has already been used?"

Also need to check if the /ok direct link has a wrong confirmation message (no mail displayed).

Files: 
CommentFileSizeAuthor
#7 simplenews-1462394-6.patch3.98 KBcorvus_ch
PASSED: [[SimpleTest]]: [MySQL] 1,693 pass(es).
[ View ]
#4 simplenews-1462394-4.patch3.64 KBcorvus_ch
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch simplenews-1462394-4.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 simplenews-1462394-2.patch3.04 KBcorvus_ch
PASSED: [[SimpleTest]]: [MySQL] 1,685 pass(es).
[ View ]

Comments

Assigned:Unassigned» corvus_ch

Status:Active» Needs review
StatusFileSize
new3.04 KB
PASSED: [[SimpleTest]]: [MySQL] 1,685 pass(es).
[ View ]

Status:Needs review» Needs work

+++ b/includes/simplenews.subscription.incundefined
@@ -501,8 +501,15 @@ function simplenews_confirm_subscription() {
+        // Redirect and display message if no changes are availlable.

Should be "available", one l too much.

Status:Needs work» Needs review
StatusFileSize
new3.64 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch simplenews-1462394-4.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Status:Needs review» Needs work

The last submitted patch, simplenews-1462394-4.patch, failed testing.

Status:Needs work» Needs review

StatusFileSize
new3.98 KB
PASSED: [[SimpleTest]]: [MySQL] 1,693 pass(es).
[ View ]

Status:Needs review» Fixed

Thanks, commited.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.