Removing dependency of views_php module [#1463464]

Comment	File	Size	Author
#13	Remove-views-PHP-dependency.zip	703.05 KB	Code Monkey

Comment #1

drupalninja99 CreditAttribution: drupalninja99 commented 3 March 2012 at 14:31

So far I see this in 5 places:

1. Events for rewriting dates, I agree with your assessment. I did this for expediency but I should go back and do it the right way.
2. Homepage rotator - yes I can convert this to global: custom text
3. Blog - I can just hardcode this as a normal link in html
4. Podcasts - this is the date reformatting issue
5. Gallery - this is the link thing again, I can change to a normal html link

OK this sounds pretty doable. I wish I had some help (*ahem*) but I think I can get this resolved.

Log in or register to post comments

Comment #2

Code Monkey CreditAttribution: Code Monkey commented 4 March 2012 at 02:19

What can I do to help?

Log in or register to post comments

Comment #3

drupalninja99 CreditAttribution: drupalninja99 commented 4 March 2012 at 14:54

I need to look at this again bc I definitely need php sometimes in the header, but I should kill the fields that use it for date reformatting for sure or places where global: custom text would work.

Log in or register to post comments

Comment #4

Code Monkey CreditAttribution: Code Monkey commented 5 March 2012 at 22:39

You could use the text format of PHP Code within a Global: Text Area if you still need to have PHP within the view. Just a thought.

Log in or register to post comments

Comment #5

drupalninja99 CreditAttribution: drupalninja99 commented 19 March 2012 at 16:23

Status:

Active

» Needs work

Adding to the roadmap bc this is an important 'maintenance' issue that needs to be cleaned up. I will replace all the views php fields with more appropriate fields.

Log in or register to post comments

Comment #6

drupalninja99 CreditAttribution: drupalninja99 commented 19 March 2012 at 16:35

Priority:

Normal

» Major

Changing priority

Log in or register to post comments

Comment #7

Code Monkey CreditAttribution: Code Monkey commented 27 March 2012 at 00:11

How would you name the new date format? I would like to see if I can modify the views to get this fixed.

Log in or register to post comments

Comment #8

drupalninja99 CreditAttribution: drupalninja99 commented 27 March 2012 at 00:19

Suggestions?

Log in or register to post comments

Comment #9

Code Monkey CreditAttribution: Code Monkey commented 27 March 2012 at 00:47

Machine name: openchurch_event_date
readable name: Openchurch Event Date
Format to match the current views_php format.

How does that sound?

Log in or register to post comments

Comment #10

drupalninja99 CreditAttribution: drupalninja99 commented 27 March 2012 at 00:55

I think podcast has the same issue, so maybe just openchurch_short_date.

Log in or register to post comments

Comment #11

Code Monkey CreditAttribution: Code Monkey commented 27 March 2012 at 01:14

Will do. Do I just need to export the views for you? What would make this easiest for you?

Log in or register to post comments

Comment #12

drupalninja99 CreditAttribution: drupalninja99 commented 28 March 2012 at 00:30

Ya re-export the whole feature, I can manually reconcile the view/.info file. the openchurch_short_date deal would probably be a strongarm variable inside of openchurch_defaults I am thinking.

Log in or register to post comments

Comment #13

Code Monkey CreditAttribution: Code Monkey commented 28 March 2012 at 15:20

Status:

Needs work

» Needs review

File	Size
Remove-views-PHP-dependency.zip	703.05 KB

Here is a zip file containing the exported features.

You will want to check the default feature to make sure the superfish error is fixed. I manually modified the included strongarm file to fix the error.

Log in or register to post comments

Comment #14

drupalninja99 CreditAttribution: drupalninja99 commented 30 March 2012 at 14:11

Excellent, ya I am going to go through these and merge changes

Log in or register to post comments

Comment #15

drupalninja99 CreditAttribution: drupalninja99 commented 30 March 2012 at 22:47

Ya these look pretty good, I have the oc short date in my defaults info and strongarm but for some reason on my local tests it isn't initializing when I run the install. Troubleshooting for the moment.

Log in or register to post comments

Comment #16

drupalninja99 CreditAttribution: drupalninja99 commented 30 March 2012 at 23:48

OK I got this working in head now.

Basically the strongarm stuff wasn't working for the date, there are additional pieces to it. So I opted to put that code in the openchurch_defaults.install file as opposed to trying strongarm.

I also added an _update_N() hook as I would like to have a consistent upgrade path so that people can upgrade cleanly from one version to the next.

I had to make a small fix to the podcasts view which had a couple small bugs in it but now that is looking correct. I haven't removed the views php module or anything, it has basically just been 'deprecated' since we are no longer using it.