can't edit or delete a og role

Is it happening on a clean Drupal installation?

Ok, I see the problem, I'll be working on a fix.

The same problem.

drupal-7.12
Views 7.x-3.3
Views Bulk Operations 7.x-3.0-rc1+3-dev
Chaos tools 7.x-1.0-rc1+117-dev
Entity API 7.x-1.0-rc1+42-dev
Entity Reference 7.x-1.0-beta5+0-dev
Organic groups 7.x-2.0-alpha1+18-dev

Patch fixes roles UI paths + moving access validation from og_ui_admin_roles() to access callbacks.

Cleaning up my previous patch.

@marshallexcavating,
I was able to apply properly. Make sure your 2.x branch is up-to-date (git pull) and use git apply to apply the patch.

Enhancing previous patch: Applying same URLs logic to roles and permissions editing + Further clean-ups.

- Can't edit permissions of per-entity roles (404 error) on group/node/[nid]/admin/permission/[rid]/edit
- Links should be hidden when editing single role/ single permissions (see image)
- Improve title callback, to make it clear on which context we are

Fixing issues according to comment #10 + Updating permissions test with the new URLs.

Getting very close

+++ b/og_ui/og_ui.admin.incundefined
@@ -242,64 +242,38 @@ function og_ui_admin_account($group_type, $gid) {
+    // If rid is given, load bundle and type from the role.

Maybe better: "Get group type and bundle from role."

+++ b/og_ui/og_ui.admin.incundefined
@@ -470,57 +456,86 @@ function theme_og_ui_admin_new_role($variables) {
+ * Retrieve roles.

Helper function to get role names.

+++ b/og_ui/og_ui.admin.incundefined
@@ -470,57 +456,86 @@ function theme_og_ui_admin_new_role($variables) {
+function og_ui_get_role_names($group_type, $gid, $bundle, $rid) {

I think it's a very custom function, lets prefix it with _ (i.e. function _og_ui...)

+++ b/og_ui/og_ui.admin.incundefined
@@ -470,57 +456,86 @@ function theme_og_ui_admin_new_role($variables) {
+    if ($group && og_is_group($group_type, $group)) {

At this point we shouldn't be getting wrong data, so we don't need to check again of the group was properly loaded.

+++ b/og_ui/og_ui.admin.incundefined
@@ -470,57 +456,86 @@ function theme_og_ui_admin_new_role($variables) {
+ * @param $form
+ * @param $form_state

No need to document these two variables.

+++ b/og_ui/og_ui.admin.incundefined
@@ -470,57 +456,86 @@ function theme_og_ui_admin_new_role($variables) {
+ *  Role ID. When specified, edit only this role's permissions.

Missing space in start of line.

+++ b/og_ui/og_ui.admin.incundefined
@@ -470,57 +456,86 @@ function theme_og_ui_admin_new_role($variables) {
+  // If rid is given, load bundle and type from the role.

Same as one of the previous comments.

+++ b/og_ui/og_ui.moduleundefined
@@ -71,26 +71,42 @@ function og_ui_menu() {
+    'page arguments' => array('og_ui_admin_roles', 1, 2, '', 5),

Please document why we pass an empty string.

+++ b/og_ui/og_ui.moduleundefined
@@ -130,12 +146,33 @@ function og_ui_menu() {
+    'title arguments' => array('OG @type - @bundle permissions', 4, 5),
+    'title callback' => 'og_ui_menu_bundle_roles_title_callback',

Fox consistency, please move the "title callback" above "title arguments".

+++ b/og_ui/og_ui.moduleundefined
@@ -200,26 +265,107 @@ function og_ui_user_access_group($perm, $group_type, $gid) {
+ * Menu access; Check permissions bundle editing.

bundle => per-bundle

+++ b/og_ui/og_ui.moduleundefined
@@ -200,26 +265,107 @@ function og_ui_user_access_group($perm, $group_type, $gid) {
+  if (!$role) {
+    return FALSE;
+  }
+

you can short it by return $role;

+++ b/og_ui/og_ui.moduleundefined
@@ -200,26 +265,107 @@ function og_ui_user_access_group($perm, $group_type, $gid) {
+    return FALSE;

Add docs -- // Role doesn't exist, or doesn't belong to the group.

+++ b/og_ui/og_ui.moduleundefined
@@ -254,6 +400,33 @@ function og_ui_menu_title_callback($title, $entity_type, $etid) {
+ * Title callback; Return the title of a group bundle

Maybe better: Return the title for editing role or permissions, based on context.

+++ b/og_ui/og_ui.moduleundefined
@@ -254,6 +400,33 @@ function og_ui_menu_title_callback($title, $entity_type, $etid) {
+      $title = str_replace('@bundle', 'Global', $title);

t('Global')

+++ b/og_ui/og_ui.moduleundefined
@@ -254,6 +400,33 @@ function og_ui_menu_title_callback($title, $entity_type, $etid) {
+    $title = str_replace('@role', $role->name, $title);

XSS... need to check_plain($role->name);

+++ b/og_ui/og_ui.moduleundefined
@@ -254,6 +400,33 @@ function og_ui_menu_title_callback($title, $entity_type, $etid) {
+  if (array_key_exists('label', $entity_info)) {

better use !empty() instead of array_key_exists().

+++ b/og_ui/og_ui.moduleundefined
@@ -254,6 +400,33 @@ function og_ui_menu_title_callback($title, $entity_type, $etid) {
+    $title = str_replace('@type', $entity_info['label'], $title);
+    $title = str_replace('@bundle', $entity_info['bundles'][$bundle]['label'], $title);

Again, need to check_plain() the $entity_info[...

Just tested patch in #11. It fixes the problem.

Amending patch according to comment #14 + Fixing wrong title when editing bundle's role.

Committed, thanks.