Currently the function _get_facebook_locale() serializes the locale array before caching it - as far as I know this is superfluous since the cache handler will take care of serialization if necessary.
Further the serialization has the side-effect that even an empty array isn't recognized as empty by this condition if (empty($cache->data)) {

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Issue summary: View changes
FileSize
903 bytes

This needed an update script to clear any existing cache.

DamienMcKenna’s picture

Version: 7.x-2.x-dev » 6.x-1.x-dev
FileSize
891 bytes

A version of the patch for the 6.x-1.x branch.

DamienMcKenna’s picture

FileSize
891 bytes

The first update for the 6.x-1.x branch should be 6100.

DamienMcKenna’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev
FileSize
883 bytes

A version of the patch for the 6.x-2.x branch.

DamienMcKenna’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev

Bumping this back to the 7.x-2.x branch, which is where reviews should start.