When I try post message I get error message "is a registered user name. Please enter a different name."
see http://www.diigo.com/item/image/1941f/ktgv?size=o

My settings

Mode: Site guestbook only
Title: Guestbook
Intro text: "empty"

User Guestbooks: User profile

DISPLAY OPTIONS
  Entries per page: 100
  Toggle display:
     + Submission date
     + Anonymous poster e-mail
     + Anonymous poster website
     + Comments
  Position of pager: Below the entries

POSTING SETTINGS
  + Publish entries by default
  Anonymous poster fields:
    + E-mail
    + Website
  Location of entry submission form: Below entries

see http://www.diigo.com/item/image/1941f/srqd?size=o

CommentFileSizeAuthor
#2 error-messsage-1467828-5686548.patch717 bytesAexChecker
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AexChecker’s picture

I think problems in using isset()

/**
 * Form validation function for guestbook_form_entry_form.
 */
function guestbook_form_entry_form_validate($form, &$form_state) {
  // Check whether name of anonymous user is an registered user's name.
  if (isset($form_state['values']['anonname'])) {
    if ($existing = user_load_by_name($form_state['values']['anonname'])) {
      form_set_error('anonname', t('%name is a registered user name. Please enter a different name.', array('%name' => $form_state['values']['anonname'])));
    }
  }
}
AexChecker’s picture

Better use !empty()

/**
 * Form validation function for guestbook_form_entry_form.
 */
function guestbook_form_entry_form_validate($form, &$form_state) {
  // Check whether name of anonymous user is an registered user's name.
  if (!empty($form_state['values']['anonname'])) {
    if ($existing = user_load_by_name($form_state['values']['anonname'])) {
      form_set_error('anonname', t('%name is a registered user name. Please enter a different name.', array('%name' => $form_state['values']['anonname'])));
    }
  }
}
Eric_A’s picture

Status: Active » Needs review
Issue tags: +Needs backport to D6

Right, this issue looks like a side effect of #1386136: Undefined indexes in guestbook_form_entry_form_submit().

Eric_A’s picture

Priority: Normal » Major
Status: Needs review » Fixed

Thanks for reporting this issue and submitting the patch!
I've spent some time with this and I'm comfortable committing this as is.

Pushed to 7.x-2.x and 6.x-2.x.

Automatically closed -- issue fixed for 2 weeks with no activity.