How is this module coming along? [#1468556]

Comment #1

dwkitchen CreditAttribution: dwkitchen commented 15 March 2012 at 11:05

I have had a limited amount of time to work on it recently and was concentrating on the Commerce Recommender Module, but will start looking at it again over the next month

Log in or register to post comments

Comment #2

marcoka CreditAttribution: marcoka commented 15 June 2012 at 16:53

i have been added co maintainer. locally i have a working version running. i will commit it soon.

Log in or register to post comments

Comment #3

Stan Turyn CreditAttribution: Stan Turyn commented 15 June 2012 at 18:11

Great news! Cheers. I'll be testing it right away with Commerce.

Log in or register to post comments

Comment #4

Stan Turyn CreditAttribution: Stan Turyn commented 18 June 2012 at 15:36

Done initial testing - great job, e-anima! Thanks so much.

So far only tested the field in account registration - works well (a couple of minor issues). Will try the field in a custom checkout pane in Commerce tomorrow.

The 1st minor issue is - we get "Error, see message: INVALID_INPUT" message having entered random letters into the field. This message seems a bit superfluous as we also get the expected "The VAT number is invalid..." error message.

The 2nd one is more of a suggestion - VAT numbers in the UK, for example, are traditionally written with spaces while in Malta - together but with a dash in the middle. Maybe it's worth checking for spaces/special characters and stripping them before attemping to validate the number?

Log in or register to post comments

Comment #5

dwkitchen CreditAttribution: dwkitchen commented 18 June 2012 at 15:59

Version:

» 7.x-1.x-dev

Thanks for the work e-anima,

Not sure what had happened but your commits didn't seem to be attached to a branch so I have merged them in to the 7.x-1.x branch and added a dev release.

Stan, thanks for the feedback on case 2 its also dots in Belgium - my original intention was to have have a drop down for the country code so they don't try and enter one without and to strip special characters when sending it to be validated but storing it in the DB as input.