Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
How is the progress on this? Do you maybe need assistance?
How is the progress on this? Do you maybe need assistance?
Comments
Comment #1
dwkitchen CreditAttribution: dwkitchen commentedI have had a limited amount of time to work on it recently and was concentrating on the Commerce Recommender Module, but will start looking at it again over the next month
Comment #2
marcoka CreditAttribution: marcoka commentedi have been added co maintainer. locally i have a working version running. i will commit it soon.
Comment #3
Stan Turyn CreditAttribution: Stan Turyn commentedGreat news! Cheers. I'll be testing it right away with Commerce.
Comment #4
Stan Turyn CreditAttribution: Stan Turyn commentedDone initial testing - great job, e-anima! Thanks so much.
So far only tested the field in account registration - works well (a couple of minor issues). Will try the field in a custom checkout pane in Commerce tomorrow.
The 1st minor issue is - we get "Error, see message: INVALID_INPUT" message having entered random letters into the field. This message seems a bit superfluous as we also get the expected "The VAT number is invalid..." error message.
The 2nd one is more of a suggestion - VAT numbers in the UK, for example, are traditionally written with spaces while in Malta - together but with a dash in the middle. Maybe it's worth checking for spaces/special characters and stripping them before attemping to validate the number?
Comment #5
dwkitchen CreditAttribution: dwkitchen commentedThanks for the work e-anima,
Not sure what had happened but your commits didn't seem to be attached to a branch so I have merged them in to the 7.x-1.x branch and added a dev release.
Stan, thanks for the feedback on case 2 its also dots in Belgium - my original intention was to have have a drop down for the country code so they don't try and enter one without and to strip special characters when sending it to be validated but storing it in the DB as input.
Comment #6
dwkitchen CreditAttribution: dwkitchen commentedI have created an issue for using a drop down to ensure a valid country code is entered:
#1645406: Validate VAT number formats in module
And for error messages #1645412: Improve user feedback and add translation