This is an issue to make sure all the tests report a success. Due to the backport a few form ids and page urls changed, these are reflected in the patches too.

The patches here incorporate the patch in #1470420: Bug in install file as well.

CommentFileSizeAuthor
#9 click_second_delete-1471766-9.patch966 bytessdrycroft
#6 1471766-6.patch5.46 KBNick_vh
#5 1471766-apachesolr-fix_tests.patch5.53 KBsnufkin
#3 1471766-apachesolr-fix_tests.patch5.54 KBsnufkin
#2 1471766-apachesolr-fix_tests.patch4.9 KBsnufkin
#1 1471766-apachesolr-fix_tests.patch4.08 KBsnufkin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

snufkin’s picture

snufkin CreditAttribution: snufkin commented
Status: Active » Needs work
FileSize
1471766-apachesolr-fix_tests.patch4.08 KB

Access related tests are fixed. Fixed database query, changed path and form alter for the permission rebuild since that changed between 6 and 7.

snufkin’s picture

snufkin CreditAttribution: snufkin commented
Status: Needs work » Needs review
FileSize
1471766-apachesolr-fix_tests.patch4.9 KB

One fail left, rest is, mostly just rearranging the dependencies and fixing the settings urls.

snufkin’s picture

snufkin CreditAttribution: snufkin commented
FileSize
1471766-apachesolr-fix_tests.patch5.54 KB

Fixing the removal of the search page fail by making the test hit the second delete link instead of the first one, which is the taxonomy/term/% search, coming with the default install.

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented

Locally this gives me 583 passes, 1 fail, and 4 exceptions

Almost! Really well done :)

Also when autoload is enabled (not necessarily in the simpletest environment) it gives you more exceptions and errors. But I don't think you should take care of this problem in this phase.

Undefined variable: env_id Notice apachesolr_base.test 134 DrupalSolrOfflineEnvironmentWebTestCase->testEditSearchEnvironmentURLs()
Undefined variable: env_id Notice apachesolr_base.test 134 DrupalSolrOfflineEnvironmentWebTestCase->testEditSearchEnvironmentURLs()
Undefined variable: env_id Notice apachesolr_base.test 134 DrupalSolrOfflineEnvironmentWebTestCase->testEditSearchEnvironmentURLs()
Undefined variable: env_id Notice apachesolr_base.test 134 DrupalSolrOfflineEnvironmentWebTestCase->testEditSearchEnvironmentURLs()

Search Environment was succesfully deleted Other apachesolr_base.test 350 DrupalSolrOfflineSearchPagesWebTestCase->testNewAndRemoveSearchPage()

Thanks!

snufkin’s picture

snufkin CreditAttribution: snufkin commented
FileSize
1471766-apachesolr-fix_tests.patch5.53 KB

I wonder why this didnt trigger an error on my end. I've updated the patch with making that call not use env_id (it does not seem to be initialized beforehand, so probably not needed).

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
FileSize
1471766-6.patch5.46 KB

Improved patch, fixes one more error

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
Status: Needs review » Fixed

Commited to 6.x-3.x

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
Status: Fixed » Closed (fixed)
sdrycroft’s picture

sdrycroft CreditAttribution: sdrycroft commented
Version: 6.x-3.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Closed (fixed) » Needs review
FileSize
click_second_delete-1471766-9.patch966 bytes

The DrupalSolrOfflineSearchPagesWebTestCase test no longer passes, as the clickLink(t('Delete')) call clicks the wrong Delete link. This is probably because of the addition of a disabled "taxonomy/term/%" search page. Changing the clickLink() function to click the second Delete link fixes this issue.

Status: Needs review » Needs work

The last submitted patch, 9: click_second_delete-1471766-9.patch, failed testing.