As (creation) is translated I ran into a freaking issue where my workflow was built in a development environment which default language was french then deployed via Features on a test environment which default language was english. My workflow was completely broken and workflow UI was quite strange. I fixed the (creation) state name in the database then everything is now running.

Digging a bit in the code, I found many places where tests are made direclty on state translated name instead of its sysid. I think this should be changed to be more reliable.

For example :

$min = $state->status == t('(creation)') ? 1 : 2;

should be

$min = $state->sysid == WORKFLOW_CREATION ? 1 : 2;
CommentFileSizeAuthor
#6 workflow-1.0.patch4.94 KBdob_
#1 workflow-1475930-1.patch4.88 KBBastlynn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bastlynn’s picture

Bastlynn CreditAttribution: Bastlynn commented
FileSize
workflow-1475930-1.patch4.88 KB

If you'll try this patch out and let me know if it works. If so, I'll commit it to dev.

Bastlynn’s picture

Bastlynn CreditAttribution: Bastlynn commented
Status: Active » Needs review

Set to NR.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented

Thank you for this work.
I will test it asap but I am a bit busy these times sorry.

rokr’s picture

rokr CreditAttribution: rokr commented
Status: Needs review » Reviewed & tested by the community

Great! Patch applies to latest dev 2012-Apr-05

In my case i put workflows into features at a local site and applied it to a dev site. While the admin on my local site uses english language the acting user at dev uses german language. It now appears that node stay at workflow status "(creation)" which is "(Erstellung)" in german which doesn't make sense to the whole workflow.

For me this patch works.

lpalgarvio’s picture

lpalgarvio CreditAttribution: lpalgarvio commented

nice fix =)

dob_’s picture

dob_ CreditAttribution: dob_ commented
Version: 7.x-1.x-dev » 7.x-1.0
FileSize
workflow-1.0.patch4.94 KB

Also created a patch for the users which will only patch this bug in version 1.0.

mvc’s picture

mvc
they
Primary language English
Location Montréal, CA
CreditAttribution: mvc commented

works for me -- thanks!

rokr’s picture

rokr CreditAttribution: rokr commented

This works again for 1.0. Thank you!
I was a little confused while i updated workflow and i hoped this patch made it into release. At least into dev branch.

cheers, rokr

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented

Applies cleanly to a Git checkout.

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented

Also included in patch in #1884630: State update conflicts with Comment form.

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-1.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.