"Only variables should be passed by reference" on viewing orders with PHP 5.4 [#1476930]

If I use PHP 5.4 to run my ubercart site, when I go to view an order, I get the following errors. Using 6.x-2.x-dev didn't solve it (as opposed to using released 6.x-2.7).

strict warning: Only variables should be passed by reference in /home/lifecome/public_html/sites/all/modules/ubercart/uc_order/uc_order.order_pane.inc on line 279.
strict warning: Only variables should be passed by reference in /home/lifecome/public_html/sites/all/modules/ubercart/uc_order/uc_order.order_pane.inc on line 517.
strict warning: Only variables should be passed by reference in /home/lifecome/public_html/sites/all/modules/ubercart/uc_order/uc_order.order_pane.inc on line 549.

Comment	File	Size	Author
#1	1476930-order-pane-render.patch	2.12 KB	longwave
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

longwave

he/him

English

CreditAttribution: longwave commented 10 March 2012 at 20:09

Status:

Active

» Needs review

File	Size
1476930-order-pane-render.patch	2.12 KB

Please test the attached patch.

Comment #2

JamesOakley

he/him/his

English

Kent, UK

CreditAttribution: JamesOakley commented 11 March 2012 at 18:14

Status:

Needs review

» Reviewed & tested by the community

I applied that patch. The "admin->view order" page still loaded fine with PHP 5.3 (so didn't break things for older PHP).

Also, with the patch, I was able to load that page with PHP 5.4 without errors. I can't comment on whether or not there are any other adverse effects, but testing thus far the issue seemed fixed.

RTBC