Handle change in top-level directory name in fully-packaged distribution tarballs [#1476994]

Coming from #863938: Top-level directory in packaged install profiles should use the shortname of the install profile project ...

sun wanted me to make sure y'all knew I was about to deploy this change, in case something in drush cares...

I'm pretty sure make *doesn't* care since this change only impacts the full "-core.tar.gz" version, and make never grabs those thanks to #1452672: Make downloads the wrong tarball for profiles.

However, I don't know the pm code as closely, haven't used it to manage distros myself, and don't have time right now to audit the code to see if it's going to be an issue or not. So, I'm hoping someone PM-enabled can either set this to "works as designed" or assigns it to themselves for a fix. ;)

Thanks!
-Derek

Comments

Comment #1

moshe weitzman CreditAttribution: moshe weitzman commented 10 March 2012 at 17:25

Status:

Active

» Closed (works as designed)

Pretty sure pm doesn't care. We just untar the file that we fetched.

Comment #2

dww

we/he/they

CreditAttribution: dww commented 10 March 2012 at 19:36

Sweet, glad to hear it. ;) Just doing due diligence here...

Cheers,
-Derek

Comment #3

jec006 CreditAttribution: jec006 commented 4 May 2012 at 01:27

Category:	task	» bug
Status:	Closed (works as designed)	» Active

This appears to be causing issues.

When I run:
drush dl panopoly

I get an error along the lines of:

copy(/tmp/drush_tmp_1336094271_4fa32e3f0552d/panopoly): failed to open stream: No such file or directory filesystem.inc:210                                                                [warning]
Project panopoly (7.x-1.0-beta2) could not be downloaded to /opt/development/jcaldwell/drupal/drupal/sites/all/modules/panopoly.                                                           [error]

I ran drush --debug dl openpublic to try to figure out what the issue was, it appears that drush is looking for the profile name, and not profilename-version.

Here is some of the info:

Calling chdir(/tmp/drush_tmp_1336092901_4fa328e564dc4) [0.94 sec, 10.21 MB]                                                                                                                    [debug]
Executing: tar -tzf openpublic-7.x-1.0-beta8-core.tar.gz
  openpublic-7.x-1.0-beta8/
  openpublic-7.x-1.0-beta8/MAINTAINERS.txt
  openpublic-7.x-1.0-beta8/PATCHES.txt

and then

Calling _drush_recursive_copy(/tmp/drush_tmp_1336092901_4fa328e564dc4/openpublic, /tmp/openpublic) [2.04 sec, 10.22 MB]                                                                        [debug]
copy(/tmp/drush_tmp_1336092901_4fa328e564dc4/openpublic): failed to open stream: No such file or directory filesystem.inc:210 [2.04 sec, 10.23 MB]                                         [warning]
Project openpublic (7.x-1.0-beta8) could not be downloaded to /tmp/openpublic. [2.04 sec, 10.23 MB]                                                                                        [error]

This appears to be happening for all profiles with release versions (some that just have dev releases seem to be ok).

(edited to add better code formatting)

Comment #4

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan commented 4 May 2012 at 15:12

Assigned:	Unassigned	» jonhattan
Priority:	Normal	» Major

Comment #5

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan commented 4 May 2012 at 15:53

Status:

Active

» Fixed

Fixed, and fixed it stopped working when "Install profiles" category changed to "Distributions" in d.o.
http://drupalcode.org/project/drush.git/commit/21c3914

Now it's also possible to

$ drush dl panopoly --drupal-project-rename
Project panopoly (7.x-1.0-beta2) downloaded to /tmp/panopoly.                                                     [success]