Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Posibillity of set the buttons position thought administration adding one setting on commerce_extra settings page to allow select the position of the +/- buttons.
Comment | File | Size | Author |
---|---|---|---|
#1 | buttonsposition-1480230-1.patch | 5.44 KB | toleillo |
Comments
Comment #1
toleillo CreditAttribution: toleillo commentedI attach the patch to allow set the position of buttons though admin pages and make some changes in the code to allow and pass the Code Sniffer validation (http://drupal.org/project/drupalcs).
Thanks.
Comment #2
klonosGreat feature! Thanx Juan ;)
Comment #3
iMiksuI've just implemented and committed an feature for handling each feature configuration as centralized way. This was needed as I've implemented feature for quantity cardinality.
Each feature may implement an configuration form, validation callback and submission callback.
Implementing configuration form
Validation callback
Submission callback
So, what about this feature request?
I'm sorry I haven't been active on this issue, I knew that this centralized configuration was needed so I waited for me implement it first before commenting on this.
This feature was requested before by drupalina in #1399390: + and - buttons to be vertically stacked and I waited for more support. Now it seems that it really is needed, so I decided that will be a feature included by to Commerce Extra.
Can we do a patch against current dev version?
Comment #4
5n00py CreditAttribution: 5n00py commentedYes, I can do this, but I need to do some review.
This is my first day as maintainer, so I need some time.
Comment #5
klonosWe got a new maintainer! Yay!!!
@5n00py: thank you Daniel for undertaking the task of maintaining the module and for taking a look at this request here. Take all the time you need ...hopefully that won't be too long though ;)
Comment #6
5n00py CreditAttribution: 5n00py commentedI leave issue in "Needs work" until next problems are resolved.
--relative[=<path>]
option for git diff