Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Found this one by accident.
I imagine it's probably not something that's going to come up practically that often -- though what about views that show the full node, will they get that too?
Comments
Comment #1
joachim CreditAttribution: joachim commentedYup, it shows in Views that show 'full node'.
Comment #2
BerdirI'm not sure if there is a clear way to only show the message on node view pages other than checking the menu path.
The message should only be shown to users with administrative permissions, so it's not a huge issue.
Comment #3
joachim CreditAttribution: joachim commentedHmm yes it's rather unfortunate that the $page parameter has gone completely -- this sort of use case could be used to argue it's a regression in Drupal core.
Comment #4
dgtlmoon CreditAttribution: dgtlmoon commentedNot real sure how else to deal with this.. suggestions? not quite a bug.. but might need some better ideas to indicate that its a newsletter edition?
Comment #5
joachim CreditAttribution: joachim commentedWe should add the missing params to simplenews_scheduler_node_view() -- http://api.drupal.org/api/drupal/modules!node!node.api.php/function/hook... -- and only output the message if the node is full view.
This will still show on views that show full entity view though.
The only thing I can think of is to do a hack and check the path... or the slightly cleaner version, http://api.drupal.org/api/drupal/includes!menu.inc/function/menu_get_obj....
Comment #6
dgtlmoon CreditAttribution: dgtlmoon commentedI think we can probably even remove this message altogether, because the admin will know when he see's the [newsletter] tab, what do you think?
Comment #7
BerdirThat would be possible. We could also add it to $node->content and expose it as an extra field, then admins can hide and show it on whatever content types they want it.