Rename submit buttons

When used in the Image library context, we should likely be using 'Select' and not 'Save' since nothing actually 'Saves' the field data until the users clicks Save on the node itself.

Changes also need to be fixed in 7.x-2.x first, then backported to 7.x-1.x as appropriate. Downgrading to normal.

It seems this patch needs a slight update. Patch won't apply.

Here's an updated patch from #6

Looking good.

patch from #8 breaks the upload functionality in the popup on a node form,
more specifically, the following part:

@@ -113,6 +113,10 @@ function media_browser($selected = NULL) {
         '#attributes' => array('class' => array('button', 'button-no', 'fake-cancel', $key)),
         '#weight' => 100,
       );
+      $plugin_output[$key]['form']['actions']['submit'] = array(
+        '#type' => 'submit',
+        '#value' => t('Upload'),
+      );
     }
   }

removing above lines fixes the issue

I'm reviewing this patch.

Marked #1870104: Change 'Submit' button to be more explicit. as a duplicate.

g10 is correct that this breaks uploading. I think this is because the upload form is being altered after drupal_get_form() is called in MediaBrowserUpload.inc If I use a normal form_alter() I'm able to change the button value properly but it does not work if it is done after the form is already built and then the value is changed.

I think the solution here is to either
* use form alter with the media upload functionality to change it
* conditionally set the value of the submit button if a submit button is not present

There is a bigger discussion about how content is delivered to the media browser is structured- is it a standard form, rendered html, should we require the save/submit/cancel buttons to be provided by the implementer? That is probably too much for this issue, but it is something that needs to be looked at.

The 6 year old patch in #13 does not apply to the latest media 7.x-2.x-dev and if still relevant needs a reroll.

Checking patch includes/media.browser.inc...
error: while searching for:
    // This is a fairly broad assumption.
    if (empty($plugin_output[$key]['#form']) && !empty($plugin_output[$key]['#markup'])) {
      $fake_buttons = '<div class="form-actions form-wrapper">';
      $fake_buttons .= l(t('Submit'), '', array('attributes' => array('class' => array('button', 'button-yes', 'fake-submit', $key))));
      $fake_buttons .= l(t('Cancel'), '', array('attributes' => array('class' => array('button', 'button-no', 'fake-cancel', $key))));
      $fake_buttons .= '</div>';
      $plugin_output[$key]['#markup'] .= $fake_buttons;

error: patch failed: includes/media.browser.inc:81
error: includes/media.browser.inc: patch does not apply

Checking patch js/media.format_form.js...
error: js/media.format_form.js: No such file or directory

Checking patch modules/media_internet/media_internet.module...
error: while searching for:
  $form['actions'] = array('#type' => 'actions');
  $form['actions']['submit'] = array(
    '#type' => 'submit',
    '#value' => t('Submit'),
  );
  return $form;
}

error: patch failed: modules/media_internet/media_internet.module:102
error: modules/media_internet/media_internet.module: patch does not apply

Renamed Submit Button

Renamed Submit Button to Save