Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Once #919224: Allow use of subtrees or individual file from archives instead of the whole archive lands in Drush core, we're going to want to allow this attribute for d.o packaging to solve the kinds of problems described at #1481158: how to deal with problem third party libraries?. This is blocked on #919224 but I wanted to open an issue about it so we don't forget and so interested parties can follow this to track progress.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1482888-4.subtree.patch | 672 bytes | dww |
Comments
Comment #1
bonobo CreditAttribution: bonobo commentedLet us know if/how we can help on this.
Comment #2
dwwIt's the other issue. This is about a 9 byte change to a validation function to add 'subtree' to an array of allowed values, and some documentation edits. ;) getting the feature itself in drush with solid tests is where to help.
Thanks!
-Derek
Comment #3
jhedstromThe other issue was resolved today.
Comment #4
dwwSweet! That was fast. ;)
In that case, here'a s patch. Untested, but probably all we need. I don't think we need a test for this here if the feature itself is working in drush -- just ensuring the attribute whitelist works for this keyword is probably overkill (although if someone wants to add a test I certainly won't stop them).
Comment #5
jgraham CreditAttribution: jgraham commentedPatch applies cleanly and looks safe. Drush itself already has tests to cover the new feature and I agree a test to check the whitelist works seems overkill.
What can I help with to get this on d.o?
Comment #6
dwwYou could apply the patch and manually test building a .make file that uses this feature with the --drupal-org option set and make sure it actually works.
Thanks,
-Derek
Comment #7
jgraham CreditAttribution: jgraham commentedIt looks like something happened in the commit for drush. It's no longer working compared to the patch I tested. I will follow up in the drush queue and get that resolved there first.
Comment #8
jgraham CreditAttribution: jgraham commentedrelated drush issue #1514120: subtree option no longer works
Comment #9
jgraham CreditAttribution: jgraham commented#1514120: subtree option no longer works is resolved.
Using the drupal-org makefile from julio with;
drush make --drupal-org drupal-org.make /tmp/maketest0Results in the expected directory structure for the libraries.
Comment #10
jgraham CreditAttribution: jgraham commentedWe may want to wait for #1515418: more robust test for subtree before adding this on d.o.
Leaving this as postponed for now I'll leave that to the discretion of dww or jhedstrom, although I would say RTBC since #1514120: subtree option no longer works has gone through and tests okay in both the drush tests and explicit tests against julio.
Comment #11
jgraham CreditAttribution: jgraham commentedChanging to active so this gets back on the radar.
Edit: But I think this is RTBC
Comment #12
jgraham CreditAttribution: jgraham commentedjhedstrom just committed the patch for #1515418: more robust test for subtree
This looks good to go.
Comment #13
jgraham CreditAttribution: jgraham commentedIt looks like this is live on drupal.org drush, can we close this out?
Edit: To clarify the fullcalendar and nivoslider libraries for julio are being modified as per our subtree directive. So this appears to be on drupal.org's build stack.
Comment #14
dwwWow, #13 is scary. No, this hasn't been committed, much less deployed. However, this reveals a major bug:
#2012084: drupalorg drush not enforcing certain constraints on libraries, only projects
Whoops! At least the good news is the fact this hasn't been committed and deployed isn't blocking your progress... ;)
Comment #15
AubreyR CreditAttribution: AubreyR as a volunteer commentedBump. Is this actually fixed or still postponed?